Skip to content

Conversation

@trigaut
Copy link
Contributor

@trigaut trigaut commented May 5, 2020

I think there must be a mistake in the function isdominated in exact.jl.
It was changed to transition from MathProgBase.linprog to JuMP + MOI.

The user has to define bounds lb and ub as vectors whose size are not size(A,2) but size(A,2)+1.
Two variables lbx and ubx, are defined to avoid that, but they were not properly used.

All tests pass with this fix !

@frapac
Copy link
Collaborator

frapac commented May 5, 2020

Thank for the contribution!
Is it possible to add a unit-test in test/exact.jl to test properly the function exactpruning! when we set explicitly a lower-bound and an upper-bound?

@trigaut
Copy link
Contributor Author

trigaut commented May 5, 2020

working on it !

@trigaut
Copy link
Contributor Author

trigaut commented May 5, 2020

I made tests and changed the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants