UnicodePlots: Retroactively set Unitful compat on versions 2.9 – 3.8.0#150490
Open
jmert wants to merge 1 commit intoJuliaRegistries:masterfrom
Open
UnicodePlots: Retroactively set Unitful compat on versions 2.9 – 3.8.0#150490jmert wants to merge 1 commit intoJuliaRegistries:masterfrom
jmert wants to merge 1 commit intoJuliaRegistries:masterfrom
Conversation
As mentioned in JuliaPlots/UnicodePlots.jl#430, when Unitful support was added, the implementation accidentally depended on functionality that assumed Unitful v1.6+. (JuliaPlots/UnicodePlots.jl#431 adjusts the implementation to restore compatibility with earlier versions of Unitful.) In order to support resolving valid/functional environments (e.g with the [julia-downgrade-compat][] action) across all versions of UnicodePlots, we can retroactively correct the compat range to reflect the true package requirements. [julia-downgrade-compat]: https://github.com/julia-actions/julia-downgrade-compat
Contributor
|
I'm in favor of this PR, but I have no idea if this is the correct approach or not. Maybe @giordano can review / comment ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in JuliaPlots/UnicodePlots.jl#430, when Unitful support was added, the implementation accidentally depended on functionality that assumed Unitful v1.6+. (JuliaPlots/UnicodePlots.jl#431 adjusts the implementation to restore compatibility with earlier versions of Unitful.)
In order to support resolving valid/functional environments (e.g with the julia-downgrade-compat action) across all versions of UnicodePlots, we can retroactively correct the compat range to reflect the true package requirements.
@t-bltg