Fork rebase by mgrunbauer · Pull Request #657 · KNMI/adaguc-server

mgrunbauer · 2026-03-04T12:57:04Z

No description provided.

mgrunbauer · 2026-03-04T14:48:08Z

+  time_t now = time(NULL);
+  for (auto it = child_procs.begin(); it != child_procs.end(); ++it) {
+    if (difftime(now, it->second.forked_at) > MAX_CHILD_PROC_TIMEOUT) {
+      kill(it->first, SIGKILL);


We kill process with SIGKILL, but we should send process timeout status code 34 to python.

maartenplieger · 2026-07-08T08:31:04Z


 if __name__ == "__main__":
-    testadaguc()
+    # testadaguc()


Why is this disabled

maartenplieger · 2026-07-08T08:32:32Z

+        self.env = os.environ.copy()
+        adaguc_env = runAdaguc().getAdagucEnv()
+        self.env.update({k: str(v) for k, v in adaguc_env.items()})
+        self.env["ADAGUC_CONFIG"] = f"{self.env.get('ADAGUC_PATH')}/python/lib/adaguc/adaguc-server-config-python-postgres.xml"


Should this not be ADAGUC_CONFIG?

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread python/python_fastapi_server/fork_server_supervisor.py

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.h Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.h Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread doc/Environment_Variables.md Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread python/lib/adaguc/CGIRunner.py Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread python/lib/adaguc/CGIRunner.py Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread python/python_fastapi_server/fork_server_supervisor.py Outdated

mgrunbauer commented Mar 4, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer mentioned this pull request Mar 5, 2026

DRAFT: Fork #405

Closed

7 tasks

mgrunbauer force-pushed the fork-rebase branch 4 times, most recently from f839ed7 to 474742f Compare April 20, 2026 15:50

mgrunbauer force-pushed the fork-rebase branch from 474742f to e4f627e Compare May 6, 2026 08:45

mgrunbauer force-pushed the fork-rebase branch from e4f627e to 8738672 Compare June 18, 2026 13:28

mgrunbauer force-pushed the fork-rebase branch from 8738672 to 7a7b423 Compare June 27, 2026 14:25

mgrunbauer force-pushed the fork-rebase branch from 7a7b423 to a6ecbd0 Compare June 29, 2026 19:22

mgrunbauer force-pushed the fork-rebase branch 2 times, most recently from ac95870 to 02c5d0e Compare July 7, 2026 19:14

maartenplieger reviewed Jul 8, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

maartenplieger reviewed Jul 8, 2026

View reviewed changes

Comment thread python/lib/adaguc/CGIRunner.py Outdated

maartenplieger reviewed Jul 8, 2026

View reviewed changes

Comment thread adagucserverEC/fork_server.cpp Outdated

mgrunbauer added 7 commits July 14, 2026 15:33

Experiment with forking adaguc

8352cc8

Start fork server from python

a56e50f

Process PR feedback

c3dd418

Fix various small issues

b8d6a80

Cleanup

91f7fb8

More cleanup

954733b

Process feedback

409a1bf

mgrunbauer force-pushed the fork-rebase branch from 02c5d0e to 409a1bf Compare July 14, 2026 14:45

Uh oh!

Conversation

mgrunbauer commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mgrunbauer Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maartenplieger Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

maartenplieger Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mgrunbauer Mar 4, 2026 •

edited

Loading