Fix compile issues. #69
Open
+28
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts commit 2f4cdb9.
Looking into the commits history it is clear that an Apple feature was intended to be added into Android devices; nevertheless the last update, of the sequence, was faulty making the Androids CameraController instantiation fail due to missing arguments.
Seems that all followed up commits were made from a previous parent where the issue did not exist.
A outdated test, on the sample app, has being removed due to not having any apparently functionality and compromising the build.
In alternative of this fix, the functionality intended shall be added.
Last commit adds a GitHub action for preventing future breaks of the build, testing is currently being made on fork/luisch444#1. In case it does not satisfy the project intentions, maintainers have permission to revert that commit. Also I suggest adding build requirements of the GHA to PRs.
LCH.