Fix cache entry with key with vary headers isn't deleted #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write some tests for this use-case and rebase your branch from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two cache entries are created when the response has vary headers. But when you call delete, only the entry without the vary headers in the cache key is deleted.
When you do a new call directly after deletion everything is ok. The cache entry without vary info is created again and returned. But if you use the Laravel backend, the cache entry with vary info won't be updated. (a If you repeat the call, the old cache entry with the vary info will be returned and not de fresh cache entry.
To fix this problem, we now delete both entries in the delete method.