Fix SIGSEGV when XMODIFIERS environment is missing #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, added debug logs to help users investigate the issue in case of a crash
Member
|
Hello, apologies for the delayed review. P.S. To all X11 users reading this, I’d really appreciate it if you could share which distributions you’ve tested this on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating getting SIGSEGV when loading the Minecraft with Prism Launcher and X11, and I found that
XMODIFIERSenvironment variable is missing, causing the XIM to support only basic input styles.This PR fixes that and adds debug logs to help users/developers investigate the issue in case of a crash (related or not related to this).
Also, this PR fixes the issue where IME dialog is at wrong position. (I'm unsure if it works well on other users)
I will remove debug logs if those are not needed.
EDIT: I tested this code with caramelChat mod with compiled binary. I'm using Debian (Trixie) and GNOME with X11.