Skip to content

Data sources docs #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 29, 2025
Merged

Data sources docs #1352

merged 6 commits into from
Jul 29, 2025

Conversation

AndreiKingsley
Copy link
Collaborator

closes #1293

[`DataFrame`](DataFrame.md) can be loaded from a H2 database using various methods:
[`readSqlTable`](readSqlDatabases.md), [`readSqlQuery`](readSqlDatabases.md),
[`readResultSet`](readSqlDatabases.md), and [`readAllSqlTables`](readSqlDatabases.md).
See [](readSqlDatabases.md) for more details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed word in []

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not missed. Writerside fills it with topic title. It's useful when you rename it.

[`DataFrame`](DataFrame.md) can be loaded from a MariaDB database using various methods:
[`readSqlTable`](readSqlDatabases.md), [`readSqlQuery`](readSqlDatabases.md),
[`readResultSet`](readSqlDatabases.md), and [`readAllSqlTables`](readSqlDatabases.md).
See [](readSqlDatabases.md) for more details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed in [] for all pages, please check


## Read

[`DataFrame`](DataFrame.md) can be loaded from a MariaDB database using various methods:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rephrase it not the direct method, but to the logic: user could read data from the SQL table by given name, as a result of user-defined SQL query, ask to fetch data from all non-system table in the database (for debugging or exploratory purposes) and from the given ResultSet

@zaleslaw
Copy link
Collaborator

zaleslaw commented Jul 29, 2025

I suppose, it's mostly done as a structure and landing pages for our PR, but could be improved on the next round

I didn't like the brevity of the page about reading from CSV, but I think we can enrich it later, there we will need to add specific use cases and people's problems, including fine tuning of the underlying Deepheaven https://kotlin.github.io/dataframe/read.html#unlocking-deephaven-csv-features

@zaleslaw zaleslaw removed the request for review from Jolanrensen July 29, 2025 14:00
@AndreiKingsley AndreiKingsley requested a review from zaleslaw July 29, 2025 15:17
@AndreiKingsley AndreiKingsley merged commit adb6e05 into master Jul 29, 2025
5 checks passed
@AndreiKingsley AndreiKingsley deleted the data_sources_docs branch July 29, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a section Data Sources and create under this section separate pages for all supported data sources
2 participants