adding .none {} to DataFrame

[CarloMariaProietti]

About issue #1431

[Jolanrensen]

Great addition! Thanks for including KDocs and tests too!

I see .all {} also has an overload on DataColumn<T>, could you do the same for .none {} while you're at it? :) that will save us work in the future

[CarloMariaProietti]

I'll try to do the same for .none {} . Should I open a new PR for this?

[Jolanrensen]

I'll try to do the same for .none {} . Should I open a new PR for this?

I think it's fine if they're in the same PR as they're siblings anyway :) thanks!

[Jolanrensen]

please run ktlintFormat to check everything is formatted right and apiDump, as you added a new public function :) Then I'll run our CI on the branch and we should be good to go :)

[AndreiKingsley]

Great, thank you!

[CarloMariaProietti]

I ran ktlintFormat but i don't know about apiDump

[Jolanrensen]

I ran ktlintFormat but i don't know about apiDump

alright, I'll do it for you this time. The idea is that you run the linter with ktlintFormat and commit the changes. It takes care of formatting and unused imports etc. apiDump updates the .api file of our module to check binary compatibility across versions (with apiCheck). This should also be run and committed for PRs :)

[Jolanrensen]

The CI agrees :) I'll merge it, thanks!