feat: intercept Kotlin go-to-definition for directories and open in Explorer #93
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrosAlexiou
force-pushed
the
feat/kotlin-directory-navigation-interceptor
branch
3 times, most recently
from
d420fb0 to
7265aea
Compare
…xplorer Prevents VSCode from showing "file is not displayed because it is a directory" errors when Kotlin LSP navigation points to package directories. Instead, automatically opens the Explorer view and highlights the target directory. - Override editor.action.revealDefinition for Kotlin files only - Check if definition targets are directories vs files - Open directories in Explorer, handle files normally - Maintain existing behavior for non-Kotlin files
AlexandrosAlexiou
force-pushed
the
feat/kotlin-directory-navigation-interceptor
branch
from
7265aea to
2c57754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract:
The LSP has the capability to resolve packages to system paths. When executing a
go to definitioncommand on a package we can use this capability in the VSCode plugin.This PR prevents VSCode from showing "file is not displayed because it is a directory"
errors when Kotlin LSP navigation points to package directories. Instead,
automatically opens the Explorer view and highlights the target directory.
PS.
I have added this feature to the Neovim plugin for the LSP: kotlin.nvim as well, so I supplied this patch for the VSCode plugin for uniformity, let me know if this is something you would like to add to the project.
Thanks!