Skip to content

[KUP] Disable opt-in Kotlin compiler warnings #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

FenstonSingel
Copy link
Contributor

It was decided to deprecate and phase out the concept (see KT-77721).

@FenstonSingel
Copy link
Contributor Author

FenstonSingel commented Jul 23, 2025

IDK what the problem with the TC build is.
It doesn't seem to be related to these changes given that it's reproducible for the master branch, though.

@FenstonSingel FenstonSingel marked this pull request as ready for review July 23, 2025 10:59
@fzhinkin
Copy link
Collaborator

IDK what the problem with the TC build is.
It doesn't seem to be related to these changes given that it's reproducible for the master branch, though.

There are two problems:

@FenstonSingel
Copy link
Contributor Author

There are two problems:

@woainikk The divergence between this public TC configuration and our internal KUP TC configuration (which, AFAICT, has been green for a while now and didn't surface any of these problems) looks like a potential issue.

@woainikk
Copy link
Contributor

The kotlin-community/dev and master in benchmarks have differences, so the configs may also differ

@FenstonSingel
Copy link
Contributor Author

The kotlin-community/dev and master in benchmarks have differences, so the configs may also differ

AFAICT, the only effective difference is 89fde29, and this difference is accounted for in the public TC configuration by passing -Pmin_supported_gradle_version=7.6.3 via the command line. So IDK, it still seems suspicious that our internal configuration is silent.

@fzhinkin fzhinkin force-pushed the ruban/kup/disable-opt-in-warnings branch from 3a66d5f to cd3a804 Compare July 24, 2025 19:29
@fzhinkin
Copy link
Collaborator

Native compilation fails for some reason (and I can't reproduce the failure outside CI)

It seems to be induced by Linux-only K/N builds we're using in a corresponding CI task. I disabled cross-compilation for that task and filed #320 to enable it back later.

@fzhinkin fzhinkin merged commit 019c7a2 into master Jul 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants