Added jvm codecs implementations #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozott00
approved these changes
Jul 30, 2025
grpc/grpc-core/src/commonTest/kotlin/kotlinx/rpc/grpc/internal/WireCodecTest.kt
Show resolved
Hide resolved
Comment on lines
+15
to
+18
| // errors in jvm are exceptions | ||
| override fun hadError(): Boolean { | ||
| return false | ||
| } |
There was a problem hiding this comment.
We should probably unify the behavior between all implementations. Probably, the K/N implementation should also throw exceptions instead of providing the error indicator? (in a separate PR)
There was a problem hiding this comment.
Yeah, let's do that in the next PR
grpc/grpc-core/src/jvmMain/kotlin/kotlinx/rpc/grpc/internal/WireDecoder.jvm.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/jvmMain/kotlin/kotlinx/rpc/grpc/internal/WireDecoder.jvm.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/jvmMain/kotlin/kotlinx/rpc/grpc/internal/WireEncoder.jvm.kt
Outdated
Show resolved
Hide resolved
Mr3zee
added a commit
that referenced
this pull request
Aug 1, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 4, 2025
Mr3zee
added a commit
that referenced
this pull request
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC
Problem Description
We had codecs for K/N but not for jvm
Solution
Add them for jvm (and fix some issues along the way)