protoc-plugin: Refactoring of intermediate model #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
… fields Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Jozott00
added
the
housekeeping
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Mr3zee
approved these changes
Aug 1, 2025
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
The GRPC services are not getting generated on this branch, so I had to comment them out. Signed-off-by: Johannes Zottele <[email protected]>
|
@Mr3zee I moved the gRPC.core tests to commonTest and commented them out. |
Mr3zee
pushed a commit
that referenced
this pull request
Aug 1, 2025
Mr3zee
pushed a commit
that referenced
this pull request
Aug 4, 2025
Mr3zee
pushed a commit
that referenced
this pull request
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Protoc Kotlin Common Plugin
Problem Description
Previously we created a Model directly from the
DescriptorProtos.*objects. The problem with this approach is, that handling the semantics of multiple protobuf versions is hard.Solution
Now, the model is build from the
Descriptor.*objects, which provide an abstraction over the raw proto descriptors. This allows us to generate protobuf version agnostic code. Additionally, message resolving is done by the descriptor, reducing the code logic on our side.This PR also removes the Kotlin JVM target of the protoc plugin and only generates Kotlin Common code.