Preserve Flow<...> in returnType and add returnsFlow flag on RpcCallable #526
+50
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Compiler Plugin, Descriptor Core
Problem Description
Descriptors for RPC methods that return
Flow<T>were exposingreturnType.kType == Tinstead of the declaredFlow<T>.It is issue #523
Solution
Stop unwrapping
Flow<T>toTinRpcStubGenerator, so the generated descriptor now keepsreturnType.kType == Flow<T>.Add
val returnsFlow: BooleantoRpcCallableand implement it inRpcCallableDefault; the compiler plugin sets this flag whenever the callable’s return type is aFlow<*>.