remove on an ordered map builder iterator succeeds after a remove of a different key - #334
Open
DmitryNekrasov wants to merge 1 commit into
Conversation
DmitryNekrasov
marked this pull request as draft
August 23, 2026 21:37
DmitryNekrasov
force-pushed
the
fix-ordered-map-iterator-remove-external-modification
branch
from
August 24, 2026 08:47
31cf5e2 to
e95f3e9
Compare
There was a problem hiding this comment.
Pull request overview
Adds fail-fast behavior to ordered-map builder iterator removal, fixing #326.
Changes:
- Checks for concurrent modification before iterator removal.
- Adds regression coverage for entries, keys, values, and size-neutral mutations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core/commonMain/src/implementations/persistentOrderedMap/PersistentOrderedMapBuilderContentIterators.kt |
Adds the missing concurrent-modification check. |
core/commonTest/src/contract/map/PersistentOrderedMapBuilderTest.kt |
Tests concurrent mutation scenarios across iterator views. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DmitryNekrasov
force-pushed
the
fix-ordered-map-iterator-remove-external-modification
branch
from
August 24, 2026 09:09
e95f3e9 to
a79e8ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove()was the only method on the ordered map builder's links iterator without the comodification checknext()carries. Unlike the two twins it never trips an assert - the builder splices both neighbours on every removal, so the chain stays consistent and the entry is just silently dropped.Fixes #326