Skip to content

Add default dns provider & provider misconfig tests #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

Add default dns provider & provider misconfig tests #780

merged 1 commit into from
Oct 14, 2025

Conversation

@averevki
Copy link
Contributor

@averevki averevki commented Oct 2, 2025

Summary

Add tests default dns provider & overlapping DNSPolicy misconfiguration cases

Closes #774, Closes #777

Changes

  • DNSPolicy with default DNS provider test
  • Multiple default DNS provider misconfiguration test
  • No default DNS provider misconfiguration test
  • No DNS provider secret exist misconfiguration test
  • delegate is true and providerRef is set on DNSPolicy misconfiguration test

Verification Steps

poetry run pytest -vv testsuite/tests/singlecluster/gateway/dnspolicy/test_delegate_and_provider_ref.py testsuite/tests/singlecluster/gateway/dnspolicy/test_no_dns_provider_secret.py testsuite/tests/singlecluster/gateway/dnspolicy/default_provider

@averevki averevki self-assigned this Oct 2, 2025
@averevki averevki added Test case New test case DNS Issues for DNSOperator labels Oct 2, 2025
@averevki averevki added this to Kuadrant Oct 2, 2025
@averevki averevki requested review from azgabur and crstrn13 October 2, 2025 11:41
@github-project-automation github-project-automation bot moved this to 🆕 New in Kuadrant QE Oct 2, 2025
@averevki averevki removed this from Kuadrant QE Oct 2, 2025
@averevki averevki moved this to Ready For Review in Kuadrant Oct 2, 2025
zkraus
zkraus requested changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@zkraus zkraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 optional - consider moving wait for the correct state into setup, as it is not actual test case

4 formatting comments - unify formatting of has_condition blocks

@averevki averevki requested review from fabikova and zkraus October 13, 2025 15:11
@averevki averevki force-pushed the default-dns-provider-tests branch from 444b570 to 7b90aff Compare October 14, 2025 08:21
zkraus
zkraus approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@zkraus zkraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: tests executed successfully for me.

@averevki averevki merged commit 300c0d8 into Kuadrant:main Oct 14, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Oct 14, 2025
@averevki averevki deleted the default-dns-provider-tests branch October 14, 2025 09:48
@averevki averevki mentioned this pull request Oct 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zkraus zkraus zkraus approved these changes

@azgabur azgabur Awaiting requested review from azgabur

@crstrn13 crstrn13 Awaiting requested review from crstrn13

@fabikova fabikova Awaiting requested review from fabikova

Assignees

@averevki averevki

Labels

DNS Issues for DNSOperator Test case New test case

Projects

Kuadrant
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add test for default dns provider secret Add tests for CoreDNS misconfiguration

2 participants

@averevki @zkraus