feat(nbt): TagStringIO Enhancements #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since adventure release 4.21.0, users can now write any BinaryTag to a String; that left a gap reading them. There is also another case where it may be useful to capture the rest of the string, for example, in a command argument. (Otherwise users would have to group count) So this commit: * Adds support to read any BinaryTag (disallows trailing like the Compound version) * Use a writer for any BinaryTag * Adds support for reading embedded any BinaryTag, and CompoundBinaryTag (Allows trailing data, through passed Appendable) * Adds support to CharBuffer to take the rest of the buffer. The special cases exist for compound methods so you can immediately throw on the first failed parsing token, even know BinaryTag's can represent a Compound
kezz
approved these changes
Jun 14, 2025
zml2008
previously requested changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since adventure release 4.21.0, users can now write any BinaryTag to a String; that left a gap in reading them.
There is also another case where it may be useful to capture the rest of the string, for example, in a command argument. (Otherwise, users would have to group count)
So this commit:
Whats with the special cases for CompoundBinaryTag a child of BinaryTag?
The special cases exist for compound methods, so you can immediately throw on the first failed parsing token, even though BinaryTags can represent a Compound; I did think about doing this through a functional interface because functions don't support checked throws, but this is more complex than it needs to be. (This wouldn't even be exposeable)