Implement #canTranslate in GlobalTranslatorImpl and call #canTranslate of its sources #1252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the other methods in the GlobalTranslator, it simply iterates through the sources and checks whether a translation is possible there.
The reason for the proposed change is that if you add a source to the GlobalTranslator which overwrites #canTranslate, the logic in there is not taken into account.
In my individual case, this is necessary because I have my own implementations of TranslatableComponent in my project, to which my Translator only reacts if the instance passed to #translate is of the type of my own implementation and therefore my Translator is no longer addressed at all.