Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR exists to track the progress on Adventure 5.0. It only exists as a PR for review purposes, once Adventure 5.0 is complete, the main branch of the repo will be changed to
main/5
.Discussion in this PR will be limited to reviews of the PR itself. For discussion about broader changes in Adventure 5.0, please see #1202.
To-do list:
The list below tracks remaining tasks. For reference, "refactor" means removal of all deprecations and refactoring of code to use modern Java language features.
annotation-processors
module.api
module.extra-kotlin
module.key
module.nbt
module.serializer-configurate-4
module.text-logger-slf4j
module.text-minimessage
module.text-serializer-ansi
module.text-serializer-commons
module.text-serializer-gson
module.text-serializer-gson-legacy-impl
module.text-serializer-json
module.text-serializer-json-legacy
module.text-serializer-legacy
module.text-serializer-plain
module.4.0 deprecations/changes
Add
ApiStatus.NonExtendible
to:Remaining discussion points
atm it's literally just used for toString, but is sometimes in the API classes and sometimes impl only - we should be consistent here