feature(nbt): getting BinaryTagType
s by their id
#1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
BinaryTagType#binaryTagType(byte id)
, to get a tag type by it's byte id.This is needed if you're writing any sort of custom serialization, as currently you can get the id to serialize, but there's no way to de-serialize.
I also changed
BinaryTagType.List TYPES
to aBinaryTagType[]
- technically hard-coding the size is not great, but seeing as:register
with any potential new tag type.it should be fine imo; still, lmk if you want me to revert it to the old list iteration & compare id approach.
Also, maybe it should return
null
instead of throwing? I just followed what the method already did, but maybe it would be better to change that, idk.