Remove unused VNC_PORT env var from vnc.dockerfile#7
Merged
Conversation
Co-authored-by: cooperj <28831674+cooperj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on VNC Container implementation regarding environment variable usage
Remove unused VNC_PORT env var from vnc.dockerfile
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VNC_PORT=5900was set but never referenced — the entrypoint hardcodes5901(TurboVNC display:1) for VNC and5801for noVNC directly.Changes
vnc.dockerfile: DropVNC_PORT=5900from theENVblock🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.