Skip to content

Process compile flag lists like link_flags #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Process compile flag lists like link_flags #724

wants to merge 1 commit into from

Conversation

eirrgang
Copy link

Add logic to blt_add_target_compile_flags() to prepend SHELL: to possible argument lists in the way that blt_add_target_link_flags().

Fixes #723

@eirrgang
Copy link
Author

Alternatively, this could be done in BLTSetupOpenMP.cmake by changing to

blt_import_library(NAME          openmp
                   COMPILE_FLAGS SHELL:${_compile_flags}
                   LINK_FLAGS    ${_link_flags}
                   EXPORTABLE    ${BLT_EXPORT_THIRDPARTY})

@eirrgang
Process compile flag lists like link_flags
fee4e26 
Add logic to `blt_add_target_compile_flags()` to prepend `SHELL:` to
possible argument lists in the way that `blt_add_target_link_flags()`.

Fixes LLNL#723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blt::openmp INTERFACE_COMPILE_OPTIONS may not delimit lists correctly.
1 participant
@eirrgang