Refactor entropy estimate #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SemyonEpanov
force-pushed
the
refactor-entropy-estimate
branch
from
f5c4497 to
df4397c
Compare
aigoncharov
reviewed
Sep 2, 2025
| adapter.check_answer_correct) | ||
|
|
||
| def main(): | ||
| ap = argparse.ArgumentParser() |
There was a problem hiding this comment.
Let's remove command-line arguments in favor of passing configs as code
aigoncharov
reviewed
Sep 2, 2025
| ans = (ans or "").strip().upper() | ||
| return ans[:1] # берем первую букву | ||
|
|
||
| def build_row_funcs_from_columns( |
There was a problem hiding this comment.
What is the point of separate prompt_builder and build_row_funcs_from_columns? AFAIU, the end goal is to construct a prompt from the row. Shall we combine them in a single function then that for MMLU dataset accepts a row and outputs a prompt?
|
Could you also refactor the existing experiments to see how the code is applied? |
aigoncharov
reviewed
Sep 9, 2025
|
|
||
| from core.prompts.mmlu_cot_answer import answer_marker as COT_MARKERS | ||
|
|
||
| def make_prompt_builder( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Объединяем дублирующийся код для извлечения энтропий CoT и single_token
#discussion_r2249304593
runner.py), стратегии (strategies.py) и общий интерфейс (estimate_entropy.py)-- Режим определяется флагом
--mode(single_tokenилиcot).