Skip to content

Conversation

@samfry13
Copy link
Contributor

@samfry13 samfry13 commented Jul 27, 2024

This PR adds a few things related to typescript types:

  • Adds prop types to any component that accepted props
  • Updated the newsletters content collection variable name to match the directory name. They previously didn't match, which meant that the zod schema was never being run on the newsletter frontmatter.
  • Adds tests to make sure newsletters are generated with the proper metadata
  • Adds title check to newsletters to make sure they follow This Month in Ladybird - <month> <year>
  • Adds a type check step to CI

@samfry13 samfry13 force-pushed the sfry/update-types branch 2 times, most recently from 699a998 to 4a89a1c Compare July 27, 2024 22:52
samfry13 and others added 5 commits October 20, 2025 13:55
@gmta gmta force-pushed the sfry/update-types branch from c6f3a9f to 01b45cd Compare October 20, 2025 11:56
@gmta gmta merged commit 8878755 into LadybirdBrowser:master Oct 20, 2025
1 check passed
@gmta
Copy link
Contributor

gmta commented Oct 20, 2025

@samfry13 Thanks for originally setting this up! I cleaned up your branch a bit and updated it for the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants