remove hard coded values and add domain #21
Conversation
| }, | ||
| "root" : {"template": "test_data/thipe-ayeye/templates/thipe-ayeye-root-template.html"} | ||
| "root" : {"template": "test_data/thipe-ayeye/templates/thipe-ayeye-root-template.html"}, | ||
| "domain": "https://ayeye-thipe-akerte.bird-apps.com" |
There was a problem hiding this comment.
The domain value should be without the protocol, so that templates can use http:// or https:// protocols as required.
| "root": {"template":"test_data/example/templates/example-template.html"}, | ||
| "domain": "https://example.com" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
As per comment in config, remove the protocol from the config.
| path: "ro-crate-preview.html", | ||
| template: multiPageConfig.root.template | ||
| template: multiPageConfig.root.template, | ||
| domain: multiPageConfig.domain |
There was a problem hiding this comment.
I wonder if it is worth checking that the domain is valid? And check/remove trailing slashes?
| <title>{{ title }}</title> | ||
|
|
||
| {# Facebook sharing image (Open Graph) #} | ||
| <meta property="og:url" content="{{ url }}" /> |
There was a problem hiding this comment.
Just noticed that this {{ url }} is wrong. Might need to be something like
{% set url = data.pages[data.entryPoint].domain ~ '/' ~ data.pages[data.entryPoint].path %}
<meta property="og:url" content="{{ url }}" />
| {% set domain = data.pages[data.entryPoint].domain %} | ||
|
|
||
| {% if domain %} | ||
| <meta property="og:url" content="https://{{ domain }}/ro-crate-preview.html" /> |
There was a problem hiding this comment.
The path here should be the path to the generated page. See comment in the subobj template for a hint
| {% set domain = data.pages[data.entryPoint].domain %} | ||
|
|
||
| {% if domain %} | ||
| <meta property="og:url" content="https://{{ domain }}/ro-crate-preview.html" /> |
There was a problem hiding this comment.
The path here should be the path to the generated page. See comment in the subobj template for a hint
No description provided.