-
Notifications
You must be signed in to change notification settings - Fork 1
Add STAMP-C3U #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice part :)
I wonder a bit why the legend polygons are only in the corners? They could be drawn as single continuous lines, one on top and one on bottom. Optionally the USB connector could also be drawn on legend (in addition to documentation) as a placement help, but not required.
Note that personally I usually do not add footprint texts like "USB-C" because in the board editor they are dragable like any other text, which is sometimes a bit annoying. But no strong opinion, it's fine to keep it.
(name_position 3.81 0.0) (name_rotation 0.0) (name_height 2.5) | ||
(name_align left center) | ||
) | ||
(pin 70e71135-f833-4fc6-867b-6229bfe55199 (name "5V_VIN") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the component this signal is called just "5V". Maybe that would be more accurate, as probably the 5V pins are actually a supply output if the module is powered by USB? Though I couldn't find details about the circuit behind the 5V pins.
(pin 70e71135-f833-4fc6-867b-6229bfe55199 (name "5V_VIN") | |
(pin 70e71135-f833-4fc6-867b-6229bfe55199 (name "5V") |
Side note: I wonder if we should draw the USB connector in the symbols of such modules, as this can make a schematic more expressive regarding power supply concept (if the whole PCB is USB powered). For the Lolin D1 Mini I've drawn it but it's not consistent with most other modules:
@@ -0,0 +1,512 @@ | |||
(librepcb_package f9774951-3f14-4d39-b5b1-50030eef0c69 | |||
(name "M5STACK_STAMP_C3U") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the naming conventions say nothing about replacing dashes by underscores 😁 We already use dashes in a lot of package names so I would keep the original naming here.
(name "M5STACK_STAMP_C3U") | |
(name "M5STACK_STAMP-C3U") |
SUMMARY
Add STAMP-C3U board with an ESP32-C3.
DATASHEETS / REFERENCES
See https://shop.m5stack.com/products/m5stamp-c3u-mate-with-pin-headers?variant=42341016633601
OPEN QUESTIONS / UNRESOLVED ISSUES
n/a
CHECKLIST
¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0