-
Notifications
You must be signed in to change notification settings - Fork 108
Track stride and make full_like respect permuted axes
#2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shino16
wants to merge
5
commits into
main
Choose a base branch
from
stride
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Now #2680 does not raise AssertionError, but gives a segmentation fault instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to fixes #2680. This work is experimental.
Change 1
torch.full_like(a)'s behavior is changed to align with eager mode whena's axes are permuted. In such cases,full_like(a)in Thunder will now return a view whose axes are permuted likewise.To achieve this in Thunder,
clang.full_like(a)creates a view with axes transposed accordingly. This happens only when we need axis permutation.The same applies to
zeros_likeandones_likewhich rely onfull_like.Change 2
TensorProxy(andFutureTensorProxy) now tracks its stride, becausefull_likeneeds to know how its axes were permuted.Why we need this
In PR #2600 we introduced Inductor for fallback. Inductor needs
FakeTensors as fake inputs, and suchFakeTensors come from Dynamo, which correctly tracks strides. This leads to discrepancies whenfull_likein Thunder-compiled submodules creates a tensor with different strides, causingAssertionError(see #2680).The intention behind this PR is to see how big the changes will be if we track tensor strides. Alternatively, we could stop supporting
full_likeand leave it to Inductor fallback, or delay Inductor until we get the real input tensors.TODO