Skip to content

tests: Fix variable reference in mul_to_multimul_checker #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

tests: Fix variable reference in mul_to_multimul_checker #2709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20b4176
tests: fix variable reference in mul_to_multimul_checker
aobolensk Nov 1, 2025
8877ae4
Merge branch 'main' into fix-cpu-tensor-mul_to_multimul_checker
t-vi Nov 11, 2025
f2cf83e
Merge branch 'main' into fix-cpu-tensor-mul_to_multimul_checker
aobolensk Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions notebooks/dev_tutorials/extend.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@
"# can't handle other inputs\n",
"def mul_to_multimul_checker(a: Number | TensorProxy, b: Number | TensorProxy) -> bool:\n",
" def is_cpu(x: Number | TensorProxy) -> bool:\n",
" if isinstance(a, TensorProxy):\n",
" return a.device.devicetype == DeviceType.CPU\n",
" if isinstance(x, TensorProxy):\n",
" return x.device.devicetype == DeviceType.CPU\n",
" return True\n",
"\n",
" return all(is_cpu(x) for x in (a, b))"
Expand Down
4 changes: 2 additions & 2 deletions thunder/tests/test_extend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ def mul_to_multimul(a: Number | TensorProxy, b: Number | TensorProxy) -> TensorP

def mul_to_multimul_checker(a: Number | TensorProxy, b: Number | TensorProxy) -> bool:
def is_cpu(x: Number | TensorProxy) -> bool:
if isinstance(a, TensorProxy):
return a.device.devicetype == devices.DeviceType.CPU
if isinstance(x, TensorProxy):
return x.device.devicetype == devices.DeviceType.CPU
return True

return all(is_cpu(x) for x in (a, b))
Expand Down
Loading