Remove the --profile option
#2715
Conversation
Instead, check whether the script is under nsys via `NSYS_PROFILE_SESSION_ID`. Note that it's still possible to profile warmup iterations -- just don't specify `--capture-range cudaProfilerStart` in the `nsys` command.
wujingyue
requested review from
KaelanDt,
lantiga,
mruberry and
t-vi
as code owners
wujingyue
requested review from
crcrpar,
kshitij12345 and
mattteochen
and removed request for
kshitij12345
mattteochen
left a comment
mattteochen
left a comment
There was a problem hiding this comment.
Looks good, thank you.
|
I checked the CI errors and they are not related to this PR. Ready to merge! |
|
I wanted to read more about |
It's not official and that's a valid concern. I think it's OK because in the worst case we see an empty PS: it should be NSYS_PROFILING_SESSION_ID instead. However, that still isn't mentioned in any official documentation. |
kshitij12345
left a comment
kshitij12345
left a comment
There was a problem hiding this comment.
LGTM, thanks @wujingyue
t-vi
left a comment
t-vi
left a comment
There was a problem hiding this comment.
Thank you @wujingyue @mattteochen @kshitij12345
4 participants
Instead, check whether the script is under nsys via
NSYS_PROFILING_SESSION_ID. Note that it's still possible to profile warmup iterations -- just don't specify--capture-range cudaProfilerStartin thensyscommand.This partially rolls back #2661.