fix: stop the requested backend child - #3865
Draft
ruslandoga wants to merge 5 commits into
Draft
Conversation
ruslandoga
marked this pull request as ready for review
August 21, 2026 13:43
ruslandoga
marked this pull request as draft
August 21, 2026 14:12
Contributor
Author
|
Converting to draft until I simplify the test... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The piped
Enum.find_value/3call passed the apparent predicate in the default-value position and&elem(&1, 0)as the mapper. The mapper returned the first supervisor child ID, which was truthy, so enumeration stopped before comparing the requested backend ID.Test-first result
Before changing production code:
mix test test/logflare/backends_test.exs:827 test/logflare/backends_test.exs:8872 tests, 2 failures (99 excluded). The requested non-first backend child remained alive, and the missing-ID call returned:ok.Verification
mix test test/logflare/backends_test.exs:827:1 test, 0 failures (99 excluded).mix test test/logflare/backends_test.exs:97 tests, 0 failures (3 excluded).