Skip to content

Conversation

donmai-me
Copy link
Contributor

implements #393

@LukeMathWalker
Copy link
Owner

The implementation looks good!
Can you add a UI test for it?

You can use this one as a reference.
The test should live in this folder.

@LukeMathWalker LukeMathWalker added the waiting-for-author Can't make further progress without the issue author label Feb 15, 2025
@donmai-me
Copy link
Contributor Author

Are ui tests generated by a pavex command? I noticed that the name in a_warning_is_emitted_for_unused_constructors's cargo.toml is

[package]
name = "app_30248169"

Sorry if I missed a piece of documentation somewhere

@LukeMathWalker
Copy link
Owner

Not yet, although I should create a helper CLI to bootstrap them!
That's the hash of the crate. The way I usually go about it—name it "app_" and when you run cargo test it'll complain about missing a specific app_XXXXX, then I rename it to that 😅 Not the most polished, I know.

@donmai-me donmai-me reopened this May 10, 2025
@donmai-me
Copy link
Contributor Author

Sorry for the long delay. I redid the pr and I think I implemented the ui test. I just renamed what pavexc wrote to expectations directory and the test passes on my machine. Hope I'm doing things right

@LukeMathWalker
Copy link
Owner

/ok-to-test sha=ddc9c04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-author Can't make further progress without the issue author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants