Skip to content

Conversation

@aparrot89
Copy link
Contributor

As did here : https://github.com/MIT-LCP/mimic-code/tree/master/concepts/firstday, this pull request introduces firstday concepts to help collaborative works on MIMIC-OMOP.

There are 3 files to create materialized views :

  • lab_first_day
  • vitals_first_day
  • sapsii score

@alistairewj
Copy link
Member

Nice - this is a good idea - I'd like your opinion on a change of approach. Initially, I wrote the first day queries, then later wrote "pivoted" queries: https://github.com/MIT-LCP/mimic-code/tree/master/concepts/pivot

Pivoted queries are essentially charttime with sensible columns like heart rate, blood pressure, temperature, etc. Tables are grouped to minimize nulls (vitals table, blood gas table, etc).

Now, we can easily see that first day data can be derived from pivoted tables. And in fact I like this approach a lot better, because you can change to 48 hours, or load the pivoted data directly into memory and use the entire time series.

What do you think?

@aparrot89
Copy link
Contributor Author

Hello Alistair,
Yes that's a good idea. I'll do that for the next scores I'll calculate
Thanks for your feedback

@vojtechhuser
Copy link
Contributor

Is there a plan to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants