Skip to content

Conversation

emorway-usgs
Copy link
Contributor

@emorway-usgs emorway-usgs commented Mar 5, 2025

Initiating a pull request for the new sensible heat flux package. Capability to remain as a draft for the foreseeable future. Functionality initially implemented in the SFE Package, but will likely change as development proceeds.

  • Replaced section above with description of pull request
  • Related to pull request feat(GWE): Introduce Groundwater Energy Transport #1493
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated meson files, makefiles, and Visual Studio project files for new source files
  • Updated definition files
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

@emorway-usgs emorway-usgs marked this pull request as draft March 5, 2025 14:20
@emorway-usgs emorway-usgs force-pushed the shf branch 2 times, most recently from c02e524 to c4c83f1 Compare March 13, 2025 20:24
@emorway-usgs emorway-usgs force-pushed the shf branch 2 times, most recently from a9d0612 to 4960b17 Compare March 26, 2025 13:14
@emorway-usgs emorway-usgs force-pushed the shf branch 3 times, most recently from b51d5bd to a009e6e Compare April 1, 2025 14:20
@emorway-usgs emorway-usgs force-pushed the shf branch 3 times, most recently from c7ff0a9 to 945975f Compare April 16, 2025 22:21
@emorway-usgs emorway-usgs force-pushed the shf branch 4 times, most recently from 267356a to 645b29a Compare April 24, 2025 11:20
@emorway-usgs emorway-usgs force-pushed the shf branch 2 times, most recently from e348e9c to a5a2063 Compare May 1, 2025 12:13
@emorway-usgs emorway-usgs force-pushed the shf branch 4 times, most recently from 2ed6ccf to 34c8ac8 Compare May 9, 2025 17:08
@emorway-usgs emorway-usgs force-pushed the shf branch 3 times, most recently from 972c31f to 14d76f3 Compare May 13, 2025 15:57
@emorway-usgs emorway-usgs force-pushed the shf branch 2 times, most recently from 9a93eeb to 2970395 Compare May 22, 2025 20:07
@emorway-usgs emorway-usgs force-pushed the shf branch 3 times, most recently from 480821d to a930fd6 Compare July 8, 2025 16:37
skfogg and others added 18 commits October 15, 2025 11:27
* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* feat(shf): starting sensible heat flux capability

* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* linting new src file (#12)

* Msvs update (#13)

* meson swr (#14)

* new test problem swr (#15)

* feat(shf): starting sensible heat flux capability

* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* linting new src file (#12)

* Msvs update (#13)

* meson swr (#14)

* new test problem swr (#15)

* add swr to options block of sfe (#16)

* feat(shf): starting sensible heat flux capability

* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* linting new src file (#12)

* Msvs update (#13)

* meson swr (#14)

* new test problem swr (#15)

* add swr to options block of sfe (#16)

* latex documentation (#17)

* new shf test passing locally, but not on CI (though it once was).

* cleanup error on CI build

* feat(shf): starting sensible heat flux capability

* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* linting new src file (#12)

* Msvs update (#13)

* meson swr (#14)

* new test problem swr (#15)

* add swr to options block of sfe (#16)

* latex documentation (#17)

* new shf test passing locally, but not on CI (though it once was).

* cleanup error on CI build

* feat(shf): starting sensible heat flux capability

* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* linting new src file (#12)

* Msvs update (#13)

* meson swr (#14)

* new test problem swr (#15)

* add swr to options block of sfe (#16)

* latex documentation (#17)

* new shf test passing locally, but not on CI (though it once was).

* cleanup error on CI build

* cleaning up some of my previous blunders

* add abc intermediate between sfe and shf/swr - not currently working

* feat(shf): starting sensible heat flux capability

* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* linting new src file (#12)

* Msvs update (#13)

* meson swr (#14)

* new test problem swr (#15)

* add swr to options block of sfe (#16)

* latex documentation (#17)

* new shf test passing locally, but not on CI (though it once was).

* cleanup error on CI build

* cleaning up some of my previous blunders

* update make file

* Shf (#18)

Bringing in Katie's latest PaBST changes

* feat(shf): starting sensible heat flux capability

* checking in today's progress.  Reworked some of the previous code that unfortunately had some bad wiring

* read shf options block; will need to circle back and test TS functionality later

* changes now through _rp() routine, _ad() up next

* latest progress

* progress plus work on shf in mf6io

* couple more shf documentation files

* build file updates

* transfer wetted surface area to SFE

* A new and very basic autotest for SHF

* Better explain the new autotest

* spelling

* remove unused variable

* fix variable truncation

* remove more unused variables

* More unused variables discovered while using CI to do checks I should do locally

* fix issue related to idxbudfjf when only one transport stream reach is active

* clean up autotest

* touch-up budget object allocation when shf not active

* ruff

* '\' -> '/' in makefile (silly windows machine)

* swr working (#11)

* linting new src file (#12)

* Msvs update (#13)

* meson swr (#14)

* new test problem swr (#15)

* add swr to options block of sfe (#16)

* latex documentation (#17)

* new shf test passing locally, but not on CI (though it once was).

* cleanup error on CI build

* cleaning up some of my previous blunders

* Shf (#18)

Bringing in Katie's latest PaBST changes

* Abc 1 (#19)

* autotest of shf and swr within abc

---------

Co-authored-by: emorway-usgs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants