-
Notifications
You must be signed in to change notification settings - Fork 143
feat(shf): starting sensible heat flux capability #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emorway-usgs
wants to merge
18
commits into
MODFLOW-ORG:develop
Choose a base branch
from
emorway-usgs:shf
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c02e524
to
c4c83f1
Compare
a9d0612
to
4960b17
Compare
b51d5bd
to
a009e6e
Compare
c7ff0a9
to
945975f
Compare
267356a
to
645b29a
Compare
e348e9c
to
a5a2063
Compare
2ed6ccf
to
34c8ac8
Compare
972c31f
to
14d76f3
Compare
9a93eeb
to
2970395
Compare
480821d
to
a930fd6
Compare
4729517
to
fb5c86a
Compare
65a1263
to
652f8ce
Compare
ed46d78
to
7bbab38
Compare
9dbb392
to
33e058e
Compare
* checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * feat(shf): starting sensible heat flux capability * checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * linting new src file (#12) * Msvs update (#13) * meson swr (#14) * new test problem swr (#15) * feat(shf): starting sensible heat flux capability * checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * linting new src file (#12) * Msvs update (#13) * meson swr (#14) * new test problem swr (#15) * add swr to options block of sfe (#16) * feat(shf): starting sensible heat flux capability * checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * linting new src file (#12) * Msvs update (#13) * meson swr (#14) * new test problem swr (#15) * add swr to options block of sfe (#16) * latex documentation (#17) * new shf test passing locally, but not on CI (though it once was). * cleanup error on CI build * feat(shf): starting sensible heat flux capability * checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * linting new src file (#12) * Msvs update (#13) * meson swr (#14) * new test problem swr (#15) * add swr to options block of sfe (#16) * latex documentation (#17) * new shf test passing locally, but not on CI (though it once was). * cleanup error on CI build * feat(shf): starting sensible heat flux capability * checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * linting new src file (#12) * Msvs update (#13) * meson swr (#14) * new test problem swr (#15) * add swr to options block of sfe (#16) * latex documentation (#17) * new shf test passing locally, but not on CI (though it once was). * cleanup error on CI build * cleaning up some of my previous blunders * add abc intermediate between sfe and shf/swr - not currently working * feat(shf): starting sensible heat flux capability * checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * linting new src file (#12) * Msvs update (#13) * meson swr (#14) * new test problem swr (#15) * add swr to options block of sfe (#16) * latex documentation (#17) * new shf test passing locally, but not on CI (though it once was). * cleanup error on CI build * cleaning up some of my previous blunders * update make file * Shf (#18) Bringing in Katie's latest PaBST changes * feat(shf): starting sensible heat flux capability * checking in today's progress. Reworked some of the previous code that unfortunately had some bad wiring * read shf options block; will need to circle back and test TS functionality later * changes now through _rp() routine, _ad() up next * latest progress * progress plus work on shf in mf6io * couple more shf documentation files * build file updates * transfer wetted surface area to SFE * A new and very basic autotest for SHF * Better explain the new autotest * spelling * remove unused variable * fix variable truncation * remove more unused variables * More unused variables discovered while using CI to do checks I should do locally * fix issue related to idxbudfjf when only one transport stream reach is active * clean up autotest * touch-up budget object allocation when shf not active * ruff * '\' -> '/' in makefile (silly windows machine) * swr working (#11) * linting new src file (#12) * Msvs update (#13) * meson swr (#14) * new test problem swr (#15) * add swr to options block of sfe (#16) * latex documentation (#17) * new shf test passing locally, but not on CI (though it once was). * cleanup error on CI build * cleaning up some of my previous blunders * Shf (#18) Bringing in Katie's latest PaBST changes * Abc 1 (#19) * autotest of shf and swr within abc --------- Co-authored-by: emorway-usgs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiating a pull request for the new sensible heat flux package. Capability to remain as a draft for the foreseeable future. Functionality initially implemented in the
SFE
Package, but will likely change as development proceeds.ruff
on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettify