Maintenance prior to 1.3 release #235
Open
+1,905
−1,940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required a bit of refactoring in the discovery code. We now detect the platform architecture right upfront and use it to inform our expectation of the name of Comsol's binary folder, such as `win64` or `macarm64`. We don't expect it to behave any different on platforms that were previously already supported.
There may be situations where multiple installations of the same Comsol versions exist on the same machine, but the (current) user wants to pick the one which has a single-user license in their name. The easiest way to do that is to just change that user's PATH variable once and for all. Related discussion: MPh-py#172
These older Python versions have reached end of life, no longer receive even security fixes. What hurts us more, however, is that modern dev tools, such as UV and Ruff, are not aware of Python 3.6, and thus require work-arounds to include it.
So far, we've stuck to PEP 8, which states: > For flowing long blocks of text with fewer structural restrictions > (docstrings or comments), the line length should be limited to 72 > characters. Let's just go with 79 characters everywhere. Makes it easier to remember and also needs only one vertical line as a visual aid in the editor.
The documentation also list 'CADREADER' as an alias for the look-up key
`CADIMPORT` for the "CAD Import Module", but according to my tests it's
not actually a valid key, i.e. `client.java.hasProduct('CADREADER')`
raises "Invalid product name."
I don't remember why I required `Sphinx>= 8.2` in the first place, but it may have had something to do with rendering the type annotations in the API documentation. Which I've given up on… for now. More importantly, though, it stops `uv sync` from resolving the dependencies, as Sphinx 8.2+ does not support Python 3.10. But Sphinx 8.0 does.
Before, we had to run `tools/test.py --log` to have it display the debug-level log messages produced by MPh, which is helpful when trouble-shooting problems reported by users. This behavior is now the default. The detailed log can be suppressed by passing `--quiet` to get the old behavior. It does make it easier to see if all tests have passed at a glance, and how long it all took.
We shouldn't assume the `tests` folder is writeable. So now we use a temporary folder assigned by the operating system whenever outputting test artifacts.
Also reordered the rule sets in `pyproject.toml`, starting with the few single-letter rule sets, followed by the multiple-letter rule sets in alphabetical order. Only the `RUF` rule set was added, with a small subset of them set to be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.