Skip to content

Conversation

farooqkz
Copy link
Contributor

@farooqkz farooqkz commented Jul 3, 2023

This was suggested several times. The current algorithm only counts kills and deaths. But we know kill assists are just as important. And a medic-knight combination can be very dangerous.

@LoneWolfHT
Copy link
Member

You just broke it again. It's fine if the maps commit is broken locally, the main repo knows which one to use

You can fix it by rebasing and dropping the commit

There are also conflicts with the PR again unfortunately

@farooqkz
Copy link
Contributor Author

@LoneWolfHT Ready to merge :)

And let me know if you want it on the experimental server.

@farooqkz
Copy link
Contributor Author

farooqkz commented Apr 7, 2024

@LoneWolfHT Status?

@LoneWolfHT
Copy link
Member

You could run it on the test server, it'll be a while before I can review it

@LoneWolfHT
Copy link
Member

This needs to be well-tested on a test server, or at least merged after a ranked reset

@LoneWolfHT LoneWolfHT added the 🏗️ Ranked Reset Queue Can only be merged after the next ranking reset label Jul 11, 2024
@farooqkz
Copy link
Contributor Author

@LoneWolfHT ?

@LoneWolfHT
Copy link
Member

Last comment still stands, OK to leave open

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants