[SKETCH] Add support for CrateDB #1
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Thanks a stack for conceiving this excellent package. After learning more details about the ingredients of dlt just recently, this library certainly sparks my interest.
About
This patch attempts to add support for CrateDB. However, it is really just a sketch.
Preview
Details
Module
CREATE TEMPORARY TABLE ...
, usage was disabled, resorting to a regularCREATE TABLE ...
. Stale temporary tables would need to be pruned by other means with CrateDB.get_utc_now
utility function needed to be adjusted.Software tests
refresh_after_dml
SQLAlchemy utility function. Within the scope of this patch, that applies to adjusting test cases only, but it would need to be documented for all users using the library in a regular runtime setting together with CrateDB. It is just a single function call to be invoked after creating an SQLAlchemy engine, but it needs to take place somewhere.Problems
Other than disabling a few other software tests, this one still fails. We did not investigate closer about the root cause yet.
AssertionError: assert 'v2' == 'v1'
crate-workbench/sqlalchemy-upsert-kit#1