Skip to content

Enable persist_enable_incremental_compaction in CI #33418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Enable persist_enable_incremental_compaction in CI #33418

wants to merge 3 commits into from
+62 −15

Conversation

DAlperin
Copy link
Member

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@DAlperin DAlperin requested a review from bkirwi August 25, 2025 17:42
@DAlperin DAlperin force-pushed the dov/enable-incremental-compaction-ci branch from 5e20db0 to 71fd46c Compare August 27, 2025 15:01
@DAlperin
Copy link
Member Author

blocked by #33307

@DAlperin DAlperin marked this pull request as draft August 27, 2025 19:20
@DAlperin DAlperin force-pushed the dov/enable-incremental-compaction-ci branch 3 times, most recently from 7d33e7f to eb8455c Compare September 3, 2025 15:37
@DAlperin DAlperin force-pushed the dov/enable-incremental-compaction-ci branch 3 times, most recently from d2e548b to 1871724 Compare September 16, 2025 17:41
@DAlperin
Persist: only use PartialBatch CompactionInput when really required
f5428a8 
If we are replacing a single batch, with a single run, we can just
replace the whole thing. No need to take the (slightly) more expensive
partial batch replacement codepath.
@DAlperin DAlperin force-pushed the dov/enable-incremental-compaction-ci branch 2 times, most recently from e24d04d to df53b65 Compare September 19, 2025 19:03
@DAlperin DAlperin force-pushed the dov/enable-incremental-compaction-ci branch from df53b65 to 0097cbd Compare September 19, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkirwi bkirwi Awaiting requested review from bkirwi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DAlperin @def-