Skip to content

Conversation

aranega
Copy link
Member

@aranega aranega commented Sep 4, 2025

Relates to

Description

@aranega aranega requested a review from seankmartin September 4, 2025 14:25
Copy link

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few markers for potential questions

Copy link

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again just leaving some notes for us :)

Copy link

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small question, looks good overall, thanks!


def __init__(
self,
mask_label: int | None = None,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to keep mask_label or can it be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, good catch, I removed it from the template, but I forgot to remove it from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants