-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add support/config for InstanceSegmentationMask #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few markers for potential questions
…ackend into feature/CC-429
…ackend into feature/CC-429
this was causing all data to be one singular label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again just leaving some notes for us :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small question, looks good overall, thanks!
|
||
def __init__( | ||
self, | ||
mask_label: int | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to keep mask_label
or can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, good catch, I removed it from the template, but I forgot to remove it from there
4d29377
to
3f80993
Compare
3f80993
to
7eccd55
Compare
Relates to
Description