#DKN-208 update results page style + general app styles improvments #105
Conversation
PoC for single question rendered in the Filter question component + responsiveness hook
#DKNET-204 Polish the resposive configuration and hook
#DKN-208 #DKN-209 update results page style
|
@Salam-Dalloul could you please fix the conflicts here? I had to open this since the previous PR was still pointing to 206. Thanks! |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive redesign and refactoring of the DKNet frontend application with improved responsive design, new guided query functionality, and enhanced UI components.
- Adds new guided query/filter assistant functionality with multi-panel layout and responsive behavior
- Refactors responsive design system with standardized breakpoints and configuration management
- Updates theme, colors, typography, and component styling for improved visual consistency
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| applications/dknet/frontend/src/utils/types.ts | Adds new TypeScript interfaces for guided query components and responsive configuration |
| applications/dknet/frontend/src/utils/helpers.ts | Adds utility functions for top match detection and active filter checking |
| applications/dknet/frontend/src/utils/constants.ts | Defines responsive breakpoints, input types, and layout configuration constants |
| applications/dknet/frontend/src/theme/variables.js | Adds new grey color variants to the design system |
| applications/dknet/frontend/src/theme/Theme.tsx | Major theme updates including typography, component styles, and new UI variants |
| applications/dknet/frontend/src/pages/RepositoriesList.tsx | Complete redesign with improved layout, scroll handling, and empty state |
| applications/dknet/frontend/src/pages/LaunchPage.tsx | Simplifies layout and adds responsive image sizing |
| applications/dknet/frontend/src/pages/HomePage.tsx | Removes layout wrapper and updates loading indicator |
| applications/dknet/frontend/src/hooks/*.ts | Adds new custom hooks for responsive behavior, keyboard navigation, and filter logic |
| applications/dknet/frontend/src/components/FilterAssistantDialog/*.tsx | Complete rewrite of guided query interface with new multi-panel architecture |
| applications/dknet/frontend/src/components/*.tsx | Updates existing components with new styling, improved accessibility, and responsive behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
applications/dknet/frontend/src/components/FilterAssistantDialog/QuestionSidebar.tsx
Outdated
Show resolved
Hide resolved
applications/dknet/frontend/src/components/widgets/CheckBox.tsx
Outdated
Show resolved
Hide resolved
Salam-Dalloul
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 41 out of 41 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 41 out of 41 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if (results.length === 0 || isNaN(item.pctMatch || 0)) { | ||
| return false; | ||
| } | ||
| return index === 0 || (results.length > 0 && item.pctMatch === results[0].pctMatch); |
There was a problem hiding this comment.
The condition results.length > 0 in line 57 is redundant since it's already checked in line 54. The function returns early if results.length === 0, so this additional check is unnecessary.
| return index === 0 || (results.length > 0 && item.pctMatch === results[0].pctMatch); | |
| return index === 0 || item.pctMatch === results[0].pctMatch; |
Copilot uses AI. Check for mistakes.
2 participants
No description provided.