fix broadcast receiver not registered when application started with no ui, e.g. from settings tile or external control #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ui, e.g. from settings tile or external control
|
I'm not sure when to call Broadcasts.unregister() so I left it uncalled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #421
The broadcast receiver should not be unregistered when the App becomes invisible since it still needs to listen to Intents.ACTION_CLASH_STARTED
Intents.ACTION_CLASH_STOPPED
to correctly update clashRunning state.
However, Broadcasts.registered was never updated to true so the unregister function never acctually took effect.
The problem is that when the App is started without ui, it never became visible, so the Broadcast receiever wasn't registered at all.