feat: Dynamic OP Stack L1 gas via gas API #6899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
pedronfigueiredo
force-pushed
the
pnf/expannd-op-stack-l1-gas-fees
branch
5 times, most recently
from
b0cf270 to
0e779d8
Compare
matthewwalsh0
requested changes
Oct 21, 2025
packages/transaction-controller/src/gas-flows/OptimismLayer1GasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/OptimismLayer1GasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/OptimismLayer1GasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/OptimismLayer1GasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/OptimismLayer1GasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/OptimismLayer1GasFeeFlow.ts
Outdated
Show resolved
Hide resolved
pedronfigueiredo
force-pushed
the
pnf/expannd-op-stack-l1-gas-fees
branch
3 times, most recently
from
c0d7df5 to
3575c60
Compare
pedronfigueiredo
force-pushed
the
pnf/expannd-op-stack-l1-gas-fees
branch
from
7b8c594 to
044c238
Compare
pedronfigueiredo
changed the title
matthewwalsh0
requested changes
Oct 22, 2025
| ### Changed | ||
|
|
||
| - Bump `@metamask/base-controller` from `^8.4.1` to `^8.4.2` ([#6917](https://github.com/MetaMask/core/pull/6917)) | ||
| - Improve OP Stack layer 1 fee estimation by fetching the supported chain list from the gas API with a static fallback, using the shared Optimism gas price oracle contract for all OP Stack networks, and making `Layer1GasFeeFlow.matchesTransaction` asynchronous to support remote lookups. ([#6899](https://github.com/MetaMask/core/pull/6899)) |
There was a problem hiding this comment.
This is intended to only list external changes.
So maybe as simple as:
Identify OP stack chains using gas API ?
| export class OptimismLayer1GasFeeFlow extends OracleLayer1GasFeeFlow { | ||
| constructor() { | ||
| super(OPTIMISM_GAS_PRICE_ORACLE_ADDRESS); | ||
| async function fetchOptimismSupportedChains(): Promise<Set<number> | null> { |
There was a problem hiding this comment.
Minor, could this be a private method inside the class? Or at least at the bottom of the file to highlight what is exported?
| // BlockExplorer link: https://optimistic.etherscan.io/address/0x420000000000000000000000000000000000000f#code | ||
| const OPTIMISM_GAS_PRICE_ORACLE_ADDRESS = | ||
| const DEFAULT_OPTIMISM_GAS_PRICE_ORACLE_ADDRESS = | ||
| '0x420000000000000000000000000000000000000F'; |
There was a problem hiding this comment.
Minor, could define as Hex here instead.
| readonly #signTransaction: boolean; | ||
|
|
||
| constructor(oracleAddress: Hex, signTransaction?: boolean) { | ||
| constructor(oracleAddress?: Hex, signTransaction?: boolean) { |
There was a problem hiding this comment.
Can we simplify by removing this and relying only on getOracleAddressForChain which could return the default vault in this class rather than in the Optimism class?
| const DEFAULT_OPTIMISM_GAS_PRICE_ORACLE_ADDRESS = | ||
| '0x420000000000000000000000000000000000000F'; | ||
|
|
||
| type SupportedNetworksResponse = { |
There was a problem hiding this comment.
Minor, type below all the constants?
| } | ||
|
|
||
| protected override getOracleAddressForChain(chainId: Hex): Hex { | ||
| return DEFAULT_OPTIMISM_GAS_PRICE_ORACLE_ADDRESS as Hex; |
There was a problem hiding this comment.
Didn't we have alternate oracles in the previous commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Fetch OP Stack supported chains from the gas API with fallback, use the shared Optimism oracle, and make layer-1 flow matching async across flows and utilities.
gas.api.cx.metamask.io/v1/supportedNetworkswith a static fallback list.getOracleAddressForChain.OptimismLayer1GasFeeFlow.matchesTransactionasync; adjust logic to check remote list then fallback.OracleLayer1GasFeeFlownow accepts optional default oracle; add overridablegetOracleAddressForChain.Layer1GasFeeFlow.matchesTransactionto returnPromise<boolean>.getTransactionLayer1GasFeeto await async matcher.ScrollLayer1GasFeeFlow.matchesTransactionasync.GasFeePollertests to pass messenger object and expect async behavior.Written by Cursor Bugbot for commit 044c238. This will update automatically on new commits. Configure here.