feat!: Expose Accounts-owned controller/service methods through messenger by GuillaumeRx · Pull Request #7976 · MetaMask/core

GuillaumeRx · 2026-02-18T11:14:53Z

Explanation

Exposes all the public methods other than init or any internally used methods of the accounts-owned controllers/services throught the messenger.

This also refactors how actions are defined and bound to the messenger using registerMethodActionHandlers and MESSENGER_EXPOSED_METHODS.

The generate-method-action-type script was used to generate the action types.

This is a breaking change in the profile-sync-controller package as some of the action type names changed but none of the underlying signatures changed.

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Medium risk because it changes messenger exposure and public TypeScript action types across multiple packages, which can break downstream compilation or runtime wiring if action lists/types drift, though underlying method implementations are largely unchanged.

Overview
Exposes previously unexposed public methods via messenger for AccountsController, AccountTreeController, MultichainAccountService, AuthenticationController, and UserStorageController by standardizing on MESSENGER_EXPOSED_METHODS + messenger.registerMethodActionHandlers and adding auto-generated *-method-action-types.ts unions/types exported from package index.ts.

Breaking API surface cleanup/standardization: internal-only helpers are made private (e.g. AccountsController#getAccountExpect, AccountTreeController#resolveNameConflict), and profile-sync-controller action type names are standardized to end in Action, requiring downstream TypeScript import updates (action strings/signatures unchanged). Tests and downstream AllowedActions typings are updated accordingly, and packages add a generate-method-action-types script/dependency (tsx) plus changelog entries documenting the new actions and removals.

^{Written by Cursor Bugbot for commit 92a2528. This will update automatically on new commits. Configure here.}

GuillaumeRx · 2026-02-18T11:16:15Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


resolveNameConflict is only internally used. It doesn't make sense to have it publicly only to test its behavior in unit tests. We can do that via the public methods that uses it

I can confirm this is not used in either extension and mobile.

GuillaumeRx · 2026-02-18T11:17:30Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


This assertion was very misleading by the way. If there's no conflict the method shouldn't be called therefore no suffix should be added.

GuillaumeRx · 2026-02-18T11:18:28Z

packages/accounts-controller/src/AccountsController.ts

   * @throws An error if the account ID is not found.
   */
-  getAccountExpect(accountId: string): InternalAccount {
+  #getAccountExpect(accountId: string): InternalAccount {


We don't need this method to be public, it's only used internally.

Makes sense!

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

packages/account-tree-controller/src/types.ts

packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

GuillaumeRx · 2026-02-19T15:14:58Z

packages/profile-sync-controller/src/controllers/authentication/index.ts

I don't know what's going on here with the imports, I just made sure that the original export behavior was respected.

This certainly seems cleaner :)

GuillaumeRx · 2026-02-19T15:15:18Z

packages/profile-sync-controller/src/controllers/user-storage/index.ts

I don't know what's going on here with the imports, I just made sure that the original export behavior was respected.

packages/account-tree-controller/src/types.ts

GuillaumeRx · 2026-02-20T13:01:05Z

packages/multichain-account-service/src/MultichainAccountService.test.ts

+      const { messenger, mocks } = await setup({
        accounts: [MOCK_HD_ACCOUNT_1],
      });

-      const resyncAccountsSpy = jest.spyOn(service, 'resyncAccounts');
      await messenger.call('MultichainAccountService:resyncAccounts');
-      expect(resyncAccountsSpy).toHaveBeenCalled();
+
+      expect(mocks.EvmAccountProvider.resyncAccounts).toHaveBeenCalled();
+      expect(mocks.SolAccountProvider.resyncAccounts).toHaveBeenCalled();


we can't spy resyncAccounts at this step since registeMethodActionHandlers will register the original method not the spied one

GuillaumeRx · 2026-02-20T13:01:33Z

packages/multichain-account-service/src/MultichainAccountService.test.ts

-      const ensureCanUseSnapPlatformSpy = jest.spyOn(
-        service,
-        'ensureCanUseSnapPlatform',
+      await rootMessenger.call(
+        'MultichainAccountService:ensureCanUseSnapPlatform',
      );
-      await messenger.call('MultichainAccountService:ensureCanUseSnapPlatform');
-      expect(ensureCanUseSnapPlatformSpy).toHaveBeenCalled();


we can't spy ensureCanUseSnapPlatform at this step since registeMethodActionHandlers will register the original method not the spied one

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

packages/multichain-account-service/src/MultichainAccountService.test.ts

mcmire

Nice! The code changes themselves look good, but I had some suggestions on changelogs. (You may need to add the no-changelog label to this PR to suppress the changelog checker.)

mcmire · 2026-02-20T15:09:18Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


I can confirm this is not used in either extension and mobile.

packages/account-tree-controller/CHANGELOG.md

mcmire · 2026-02-20T15:19:05Z

packages/accounts-controller/src/AccountsController.ts

   * @throws An error if the account ID is not found.
   */
-  getAccountExpect(accountId: string): InternalAccount {
+  #getAccountExpect(accountId: string): InternalAccount {


Makes sense!

packages/account-tree-controller/CHANGELOG.md

packages/multichain-account-service/CHANGELOG.md

packages/notification-services-controller/CHANGELOG.md

packages/profile-metrics-controller/CHANGELOG.md

packages/profile-sync-controller/CHANGELOG.md

packages/subscription-controller/CHANGELOG.md

mcmire

LGTM!

…StorageController`

- Update CHANGELOGs - Remove non public-facing changes - Make entries clearer - Remove export of `*MethodActions`

GuillaumeRx requested a review from a team as a code owner February 18, 2026 11:14

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 7de355d to 0e42ff2 Compare February 18, 2026 11:15

GuillaumeRx commented Feb 18, 2026

View reviewed changes

cursor bot reviewed Feb 18, 2026

View reviewed changes

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Outdated Show resolved Hide resolved

hmalik88 reviewed Feb 18, 2026

View reviewed changes

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Outdated Show resolved Hide resolved

mcmire reviewed Feb 18, 2026

View reviewed changes

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 0e42ff2 to 6ea2c28 Compare February 19, 2026 15:10

GuillaumeRx requested review from a team as code owners February 19, 2026 15:10

GuillaumeRx commented Feb 19, 2026

View reviewed changes

cursor bot reviewed Feb 19, 2026

View reviewed changes

packages/account-tree-controller/src/types.ts Outdated Show resolved Hide resolved

GuillaumeRx requested review from a team as code owners February 19, 2026 15:30

GuillaumeRx changed the title ~~chore: Expose Accounts-owned controller/service methods through messenger~~ feat!: Expose Accounts-owned controller/service methods through messenger Feb 20, 2026

GuillaumeRx requested a review from a team as a code owner February 20, 2026 10:44

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch 2 times, most recently from be1d092 to 405c239 Compare February 20, 2026 11:19

GuillaumeRx commented Feb 20, 2026

View reviewed changes

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 31e2baa to 6867941 Compare February 20, 2026 13:04

cursor bot reviewed Feb 20, 2026

View reviewed changes

packages/multichain-account-service/src/MultichainAccountService.test.ts Show resolved Hide resolved

mcmire reviewed Feb 20, 2026

View reviewed changes

GuillaumeRx added the no-changelog label Feb 23, 2026

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 5f0e503 to 2aa9997 Compare February 23, 2026 11:13

GuillaumeRx requested a review from mcmire February 23, 2026 11:33

mcmire approved these changes Feb 23, 2026

View reviewed changes

GuillaumeRx enabled auto-merge February 23, 2026 17:53

GuillaumeRx added 25 commits February 23, 2026 18:53

migrate AccountsController to use registerMethodActionHandlers

3e2a662

migrate MultichainAccountService to use registerMethodActionHandlers

5b6abef

migrate AccountTreeController, AuthenticationController and `User…

a8275fe

…StorageController`

fix action name

0c0353c

use generate-method-action-types in account-tree-controller

1cf361b

use generate-method-action-types in accounts-controller

874e712

use generate-method-action-types in multichain-account-service

5c8357c

use generate-method-action-types in profile-sync-controller

65de3b3

revert typo

c9cf2ec

fix import

ed16319

fix action name usage

79efeb3

fix lint and exports

04c9a6c

use type only imports

1560fff

fix account-tree-controller type imports

626d4e1

fix lint, rename actions in other controllers

94b3e73

fill coverage in AccountsController

31f484d

update CHANGELOGs

d33b300

fix core-backend CHANGELOG

a61a460

fix core-backend CHANGELOG

40e6b0c

fix eslint-suppressions.json lint

8bae94b

fix claims-controller changelog

dd69bd3

fix multichain-account-service tests

82ef8ca

remove direct call to method in test

a0c4590

Address requested changes

5e63874

- Update CHANGELOGs - Remove non public-facing changes - Make entries clearer - Remove export of `*MethodActions`

fix multichain-account-service CHANGELOG

92a2528

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 170f273 to 92a2528 Compare February 23, 2026 17:53

micaelae approved these changes Feb 23, 2026

View reviewed changes

Uh oh!

Comments

Conversation

GuillaumeRx commented Feb 18, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GuillaumeRx commented Feb 18, 2026 •

edited by cursor bot

Loading