-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
POC for new flow of documentation #2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…sk-docs into feat/quick-start
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ef3ccf4
to
2ae8dde
Compare
history.replaceState = originalReplaceState; | ||
}; | ||
}, []); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Component Modifies Browser History APIs Globally
The component directly overrides global browser history APIs (history.pushState
and history.replaceState
). This dangerous practice creates global side effects that can conflict with other application parts or third-party libraries, leading to unpredictable behavior. Although a cleanup is attempted on unmount, the temporary modification itself carries inherent risks and could persist if the component unmounts abnormally.
Adds the following:
Max time was spent on maintaining the same design scheme, although a design review will be ideal