Skip to content

POC for new flow of documentation #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

POC for new flow of documentation #2179

wants to merge 36 commits into from

Conversation

yashovardhan
Copy link
Member

Adds the following:

  • Adds playground based on Web3Auth Quick Start
  • Add highlighting and blur magic comments
  • Update home page
  • Update nav bar components

Max time was spent on maintaining the same design scheme, although a design review will be ideal

@yashovardhan yashovardhan requested review from a team as code owners July 28, 2025 09:47
Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ❌ Failed (Inspect) Aug 6, 2025 2:04pm

Copy link

socket-security bot commented Jul 28, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcopy-to-clipboard@​3.3.31001009176100
Addedclassnames@​2.5.110010010079100
Addedreact-spring@​10.0.1991009982100
Addedreact-spinners@​0.17.010010010083100
Addedreact-icons@​5.5.01001001008480

View full report

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yashovardhan yashovardhan requested review from a team as code owners July 29, 2025 17:41
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yashovardhan yashovardhan requested a review from a team as a code owner July 30, 2025 04:54
cursor[bot]

This comment was marked as outdated.

history.replaceState = originalReplaceState;
};
}, []);

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Component Modifies Browser History APIs Globally

The component directly overrides global browser history APIs (history.pushState and history.replaceState). This dangerous practice creates global side effects that can conflict with other application parts or third-party libraries, leading to unpredictable behavior. Although a cleanup is attempted on unmount, the temporary modification itself carries inherent risks and could persist if the component unmounts abnormally.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant