-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Document Infura Bundler support #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
<Tabs> | ||
<TabItem value="v0.7" label="v0.7 and v0.8 user operation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current tab style is optimized for usage with code samples – the tabs use the same color and style and signify a single, continuous UI element with the code sample:
This has been fine so far because we only use tabs with code samples. I don't think this style works as well for non-code sample usage, as the tab bar appears as a completely separate element to the parameters list:
We may need to adjust the global tab style if we intend to use it outside of code samples. There are only a few instances added here, so I'm ok with addressing it in a future issue.
Co-authored-by: Alexandra Carrillo <[email protected]>
Description
Document Infura Bundler support.
Checklist
Complete this checklist before merging your PR: