test: Use real storage in E2E #38093
Merged
+248
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Builds ready [5c78682]
UI Startup Metrics (1256 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
FrederikBolding
changed the title
Collaborator
Builds ready [ba18647]
UI Startup Metrics (1339 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [192b4d9]
UI Startup Metrics (1269 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [e8cc962]
UI Startup Metrics (1254 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
FrederikBolding
commented
Nov 21, 2025
| @@ -1,16 +1,16 @@ | |||
| { | |||
| "data": { | |||
| "AuthenticationController": { "isSignedIn": "boolean" }, | |||
Member
Author
There was a problem hiding this comment.
The explanation for the big diff here is that previously we would rely on ReadOnlyNetworkStore here:
FrederikBolding
commented
Nov 21, 2025
Collaborator
Builds ready [0c65494]
UI Startup Metrics (1309 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This reverts commit 6c29eeb.
FrederikBolding
force-pushed
the
fb/use-real-storage-e2e
branch
from
0c65494 to
06c2ccb
Compare
FrederikBolding
force-pushed
the
fb/use-real-storage-e2e
branch
from
06c2ccb to
cccca99
Compare
Collaborator
Builds ready [cccca99]
UI Startup Metrics (1287 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [8b82805]
UI Startup Metrics (1218 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| async reset(): Promise<void> { | ||
| this.#initialized = false; | ||
| this.#state = null; | ||
| await super.reset(); |
There was a problem hiding this comment.
Bug: Race condition in reset method
The reset method has a race condition where #initialized is set to false before creating a new #initializing promise. If get or set is called between setting #initialized = false and this.#initializing = this.#init(), they will await the old resolved promise instead of the new initialization, potentially accessing uninitialized or reset state.
Member
Author
There was a problem hiding this comment.
I don't think this matters in practice, but can fix it if anyone feels strongly about it
GuillaumeRx
approved these changes
Nov 25, 2025
metamaskbot
added
the
release-13.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
ReadOnlyNetworkStorewithFixtureExtensionStore. This new class extendsExtensionStorewhile still seeding the initial state using the fixture server. This effectively means that all E2Es leverage the real browser storage APIs instead of an in-memory store, bringing us closer to testing actual production builds.Due to this change in behavior, the
errors-before-init-opt-in-ui-state.jsonsnapshot had to be updated as well. The snapshot is now more realistic as it contains the initialized background state, instead of just the fixture data.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Note
Replace ReadOnlyNetworkStore with FixtureExtensionStore (seeds from fixture server but uses real extension storage) and update tests and state snapshots accordingly.
FixtureExtensionStoreextendingExtensionStore, initializing fromhttp://localhost:12345/state.jsonand persisting via real browser storage; supports asyncget/set/reset.FixtureExtensionStorein test builds inapp/scripts/background.jsandlib/setup-initial-state-hooks.jsviaPersistenceManager.fixture-extension-store.test.ts(mockswebextension-polyfill, verifies network seeding and storage behavior).persistence-manager.test.tsto rely onExtensionStoremock (remove read-only store mock).errors.spec.ts: remove debug logs, add waits for state settle, and tweak Sentry assertions.errors-before-init-opt-in-ui-state.jsonto reflect initialized background state and new schema/version.PersistenceManagerwithFixtureExtensionStorein tests; add cleanup of most recent state during app-state acquisition.Written by Cursor Bugbot for commit 8b82805. This will update automatically on new commits. Configure here.