fix: social login authentication state before rehydrate cp-13.11.0 #38170

lwin-kyaw · 2025-11-24T10:52:09Z

Description

Fixed social login authentication-state validation in rehydration flow.

Changelog

CHANGELOG entry: fixed social login authentication validation in rehydrate.

Related issues

Fixes: #38172

Manual testing steps

Click on create new wallet and login with existing social login account
After completing social login, close the browser at the unlock page
Open the browser and wallet again.
You should be redirect back to the welcome page

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refactors social login onboarding to async-validate auth before redirects, adjusts first-time flow checks, and simplifies Account Exist/Not Found to navigate without mutating flow state; updates tests accordingly.

Onboarding Welcome (ui/pages/onboarding-flow/welcome/welcome.js)
- Replace getIsSocialLoginUserAuthenticated with getIsSocialLoginFlow and async auth check via getIsSeedlessOnboardingUserAuthenticated before redirecting.
- Guard redirects with isMounted flag; handle social create vs import navigation accordingly.
- Defer setting firstTimeFlowType for social flows until after OAuth result (set to socialCreate for new users, socialImport for existing).
Account pages
- account-exist.tsx and account-not-found.tsx:
  - Remove setFirstTimeFlowType dispatches; rely on navigation only.
  - In useEffect, invert/clarify conditions to show page only for the matching FirstTimeFlowType (socialImport for exist, socialCreate for not-found); otherwise redirect to ONBOARDING_WELCOME_ROUTE.
  - Add "use different login method" handler to reset onboarding state and navigate to welcome.
Tests
- Update tests to remove expectations around setFirstTimeFlowType and reflect new routing conditions and reset behavior in both account pages.

^{Written by Cursor Bugbot for commit 97b3b51. This will update automatically on new commits. Configure here.}

github-actions · 2025-11-24T10:52:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-11-24T10:53:06Z

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (5 files, +52 -48)

📁 ui/
- 📁 pages/
  - 📁 onboarding-flow/
    - 📁 account-exist/
      - 📄 account-exist.test.tsx +2 -9
      - 📄 account-exist.tsx +4 -7
    - 📁 account-not-found/
      - 📄 account-not-found.test.tsx +2 -9
      - 📄 account-not-found.tsx +4 -8
    - 📁 welcome/
      - 📄 welcome.js +40 -15

ui/store/actions.ts

ui/pages/onboarding-flow/welcome/welcome.js

metamaskbot · 2025-11-24T11:22:51Z

Builds ready [cfc6d15]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1199 ± 109 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1199	992	1587	109	1241	1444
			load	1021	852	1304	96	1055	1208
			domContentLoaded	1014	847	1296	94	1050	1200
			domInteractive	27	15	114	24	21	93
			firstPaint	527	94	1342	400	1000	1184
			backgroundConnect	210	193	250	10	213	237
			firstReactRender	28	19	149	14	29	45
			getState	31	15	90	11	35	57
			initialActions	1	0	4	1	1	2
			loadScripts	810	657	1076	92	842	1008
			setupStore	10	6	23	3	11	19
			numNetworkReqs	12	5	78	21	5	73
	Browserify	Power User Home	uiStartup	1843	1522	3114	278	2030	2415
			load	987	866	1959	185	997	1491
			domContentLoaded	973	858	1934	183	966	1480
			domInteractive	39	16	234	49	27	177
			firstPaint	531	99	1978	419	897	1459
			backgroundConnect	217	194	255	12	225	241
			firstReactRender	87	46	161	18	96	119
			getState	165	128	350	38	188	229
			initialActions	1	0	10	1	1	4
			loadScripts	772	664	1725	183	767	1263
			setupStore	21	7	89	14	28	52
			numNetworkReqs	91	63	211	33	100	185
	Webpack	Standard Home	uiStartup	834	697	1213	93	864	1042
			load	648	564	1038	81	693	829
			domContentLoaded	640	557	856	71	689	812
			domInteractive	28	16	130	25	22	104
			firstPaint	223	82	1032	159	211	626
			backgroundConnect	13	5	346	34	10	25
			firstReactRender	29	20	218	21	31	38
			getState	27	13	72	13	38	53
			initialActions	1	0	6	1	1	2
			loadScripts	637	555	848	69	687	803
			setupStore	10	5	29	4	12	17
			numNetworkReqs	12	5	76	20	5	72
	Webpack	Power User Home	uiStartup	1458	1097	2370	225	1576	1907
			load	663	568	1267	131	663	1017
			domContentLoaded	653	561	1258	131	647	1009
			domInteractive	37	17	216	42	27	160
			firstPaint	289	105	796	179	376	678
			backgroundConnect	13	7	27	5	16	23
			firstReactRender	87	50	117	13	97	108
			getState	168	142	303	33	171	264
			initialActions	1	0	3	0	1	2
			loadScripts	651	558	1249	129	646	1001
			setupStore	20	9	61	13	22	50
			numNetworkReqs	142	68	313	55	175	290
Firefox	Browserify	Standard Home	uiStartup	1209	1068	1750	104	1236	1418
			load	1016	915	1267	69	1056	1174
			domContentLoaded	1015	913	1267	70	1052	1173
			domInteractive	52	30	144	27	73	103
			firstPaint	-	-	-	-	-	-
			backgroundConnect	35	22	161	18	37	72
			firstReactRender	22	17	54	6	21	35
			getState	9	5	24	3	9	19
			initialActions	1	0	3	1	1	2
			loadScripts	994	891	1248	67	1036	1131
			setupStore	10	5	57	8	9	26
			numNetworkReqs	11	5	62	14	6	50
	Browserify	Power User Home	uiStartup	2661	1991	3557	308	2892	3321
			load	1157	932	1747	188	1225	1538
			domContentLoaded	1156	927	1747	188	1225	1538
			domInteractive	130	33	514	116	144	428
			firstPaint	-	-	-	-	-	-
			backgroundConnect	167	24	770	184	198	623
			firstReactRender	89	53	173	22	100	143
			getState	327	82	898	299	676	867
			initialActions	3	1	39	5	2	7
			loadScripts	1122	914	1729	180	1184	1484
			setupStore	97	4	705	138	104	503
			numNetworkReqs	90	59	218	43	83	196
	Webpack	Standard Home	uiStartup	1439	1292	2006	131	1504	1746
			load	1219	1077	1493	95	1286	1402
			domContentLoaded	1219	1075	1493	95	1285	1402
			domInteractive	51	27	142	28	68	114
			firstPaint	-	-	-	-	-	-
			backgroundConnect	41	16	132	20	43	89
			firstReactRender	27	20	71	8	29	35
			getState	13	6	184	21	11	38
			initialActions	1	0	3	0	1	2
			loadScripts	1197	1061	1435	90	1263	1381
			setupStore	13	5	178	18	11	33
			numNetworkReqs	12	5	66	17	6	64
	Webpack	Power User Home	uiStartup	2941	2203	3996	366	3160	3579
			load	1455	1150	1998	221	1641	1886
			domContentLoaded	1455	1150	1998	221	1640	1886
			domInteractive	145	28	774	160	131	593
			firstPaint	-	-	-	-	-	-
			backgroundConnect	206	23	1241	231	256	670
			firstReactRender	92	42	186	24	103	140
			getState	298	86	891	279	374	856
			initialActions	4	1	51	7	3	7
			loadScripts	1417	1120	1970	220	1615	1855
			setupStore	105	7	772	172	105	655
			numNetworkReqs	90	59	215	45	82	207

📊 Page Load Benchmark Results

Current Commit: cfc6d15 | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 719ms (±38ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.01s	1.35s	1.05s	1.35s
domContentLoaded	719ms	38ms	696ms	1.02s	738ms	1.02s
firstPaint	76ms	15ms	60ms	212ms	84ms	212ms
firstContentfulPaint	76ms	15ms	60ms	212ms	84ms	212ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 53 Bytes (0%)
ui: 135 Bytes (0%)
common: 63 Bytes (0%)

metamaskbot · 2025-11-24T12:12:55Z

Builds ready [97b3b51]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1190 ± 95 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1190	1008	1422	95	1245	1397
			load	1007	848	1203	84	1048	1171
			domContentLoaded	1002	845	1197	83	1044	1157
			domInteractive	27	14	115	24	21	100
			firstPaint	593	90	1202	406	1016	1172
			backgroundConnect	208	190	244	9	213	228
			firstReactRender	27	19	56	7	28	46
			getState	32	16	104	13	35	59
			initialActions	1	0	4	1	1	2
			loadScripts	799	647	999	83	838	960
			setupStore	10	6	22	3	11	18
			numNetworkReqs	12	5	77	20	5	74
	Browserify	Power User Home	uiStartup	1834	1600	2384	160	1915	2123
			load	984	883	1604	149	971	1367
			domContentLoaded	972	863	1595	149	951	1362
			domInteractive	38	17	216	43	30	162
			firstPaint	528	95	1633	397	940	1351
			backgroundConnect	217	200	251	10	222	236
			firstReactRender	81	45	145	19	89	115
			getState	165	125	255	27	184	214
			initialActions	1	0	3	1	1	2
			loadScripts	769	662	1392	149	747	1157
			setupStore	18	9	47	8	22	35
			numNetworkReqs	110	65	306	48	119	202
	Webpack	Standard Home	uiStartup	839	727	1104	79	864	1013
			load	651	578	869	68	659	829
			domContentLoaded	646	573	855	68	653	824
			domInteractive	31	17	131	27	23	108
			firstPaint	248	105	885	172	228	643
			backgroundConnect	11	5	35	5	13	24
			firstReactRender	28	20	54	7	33	39
			getState	28	14	83	12	35	47
			initialActions	1	0	4	1	1	2
			loadScripts	643	571	846	66	651	814
			setupStore	11	7	28	4	12	20
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1343	1157	1852	151	1452	1651
			load	617	541	988	104	610	925
			domContentLoaded	608	534	978	104	597	919
			domInteractive	33	16	161	34	28	128
			firstPaint	285	106	985	222	262	877
			backgroundConnect	14	7	46	7	15	34
			firstReactRender	79	44	105	14	88	103
			getState	152	130	420	31	155	181
			initialActions	1	0	4	1	1	2
			loadScripts	606	532	971	102	595	912
			setupStore	18	8	52	12	20	48
			numNetworkReqs	145	66	325	57	189	281
Firefox	Browserify	Standard Home	uiStartup	1207	1056	1688	109	1253	1458
			load	1018	898	1310	79	1070	1187
			domContentLoaded	1017	893	1310	79	1065	1186
			domInteractive	57	29	258	36	84	115
			firstPaint	-	-	-	-	-	-
			backgroundConnect	36	23	157	20	37	80
			firstReactRender	21	17	48	4	21	29
			getState	9	5	53	6	9	16
			initialActions	1	0	3	1	1	2
			loadScripts	997	882	1293	74	1045	1148
			setupStore	12	5	197	21	9	33
			numNetworkReqs	11	5	66	16	6	62
	Browserify	Power User Home	uiStartup	2453	2035	3367	263	2614	2974
			load	1111	930	1560	142	1130	1511
			domContentLoaded	1110	926	1560	142	1129	1511
			domInteractive	128	30	573	124	115	535
			firstPaint	-	-	-	-	-	-
			backgroundConnect	102	35	379	61	115	252
			firstReactRender	85	40	175	23	96	127
			getState	298	59	1362	260	420	839
			initialActions	3	0	27	3	3	7
			loadScripts	1081	910	1530	139	1101	1477
			setupStore	122	9	1254	178	110	545
			numNetworkReqs	92	59	178	33	129	150
	Webpack	Standard Home	uiStartup	1414	1267	2055	134	1445	1746
			load	1192	1072	1479	93	1240	1392
			domContentLoaded	1191	1071	1479	93	1239	1392
			domInteractive	47	26	144	28	58	114
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	17	165	23	43	93
			firstReactRender	27	21	72	7	30	36
			getState	11	6	46	7	10	19
			initialActions	1	0	2	1	2	2
			loadScripts	1169	1055	1445	88	1219	1356
			setupStore	14	5	226	24	11	56
			numNetworkReqs	12	5	67	17	6	65
	Webpack	Power User Home	uiStartup	2674	2291	3238	210	2788	3078
			load	1390	1187	2042	173	1418	1774
			domContentLoaded	1390	1187	2041	173	1418	1773
			domInteractive	113	32	563	118	100	456
			firstPaint	-	-	-	-	-	-
			backgroundConnect	105	24	488	62	122	226
			firstReactRender	84	46	172	20	90	124
			getState	239	62	852	208	302	720
			initialActions	4	1	60	8	3	7
			loadScripts	1353	1144	1997	167	1382	1742
			setupStore	127	11	679	163	117	550
			numNetworkReqs	91	61	205	38	100	179

📊 Page Load Benchmark Results

Current Commit: 97b3b51 | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±51ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 744ms (±48ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±13ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	51ms	1.04s	1.46s	1.11s	1.46s
domContentLoaded	744ms	48ms	719ms	1.12s	777ms	1.12s
firstPaint	80ms	13ms	68ms	200ms	88ms	200ms
firstContentfulPaint	80ms	13ms	68ms	200ms	88ms	200ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 291 Bytes (0.01%)
ui: 114 Bytes (0%)
common: 20 Bytes (0%)

himanshuchawla009

lgtm

fix: social login authentication state before rehydrate

cfc6d15

lwin-kyaw requested a review from a team as a code owner November 24, 2025 10:52

metamaskbot added the team-onboarding Onboarding team label Nov 24, 2025

cursor bot reviewed Nov 24, 2025

View reviewed changes

ui/store/actions.ts Outdated Show resolved Hide resolved

ui/pages/onboarding-flow/welcome/welcome.js Show resolved Hide resolved

lwin-kyaw added release-blocker This bug is blocking the next release release-13.11.0 Issue or pull request that will be included in release 13.11.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Nov 24, 2025

lwin-kyaw added 2 commits November 24, 2025 19:34

fix: fixed redirection in account-not-found/account-exist pages

2b57a49

chore: removed debug logs

97b3b51

lwin-kyaw changed the title ~~fix: social login authentication state before rehydrate~~ fix: social login authentication state before rehydrate cp-13.11.0 Nov 24, 2025

himanshuchawla009 approved these changes Nov 24, 2025

View reviewed changes

lwin-kyaw added needs-qa Label will automate into QA workspace and removed needs-qa Label will automate into QA workspace labels Nov 24, 2025

lwin-kyaw enabled auto-merge November 24, 2025 14:34

chaitanyapotti approved these changes Nov 24, 2025

View reviewed changes

lwin-kyaw added this pull request to the merge queue Nov 24, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 24, 2025

lwin-kyaw added this pull request to the merge queue Nov 24, 2025

Merged via the queue into main with commit 86412e0 Nov 24, 2025
186 of 187 checks passed

lwin-kyaw deleted the fix/social-login-rehydrate branch November 24, 2025 16:06

github-actions bot locked and limited conversation to collaborators Nov 24, 2025

metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Nov 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: social login authentication state before rehydrate cp-13.11.0 #38170

fix: social login authentication state before rehydrate cp-13.11.0 #38170

lwin-kyaw commented Nov 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

metamaskbot commented Nov 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 24, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 24, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

himanshuchawla009 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: social login authentication state before rehydrate cp-13.11.0 #38170

fix: social login authentication state before rehydrate cp-13.11.0 #38170

Conversation

lwin-kyaw commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

metamaskbot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 24, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 24, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

himanshuchawla009 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lwin-kyaw commented Nov 24, 2025 •

edited

Loading

metamaskbot commented Nov 24, 2025 •

edited

Loading