fix: Use `withKeyring` for accessing keyring entropy for Snaps by FrederikBolding · Pull Request #40296 · MetaMask/metamask-extension

FrederikBolding · 2026-02-20T15:48:40Z

Description

Use withKeyring instead of getKeyringsByType for accessing the mnemonic for Snaps. withKeyring has more guarantees that should prevent race conditions and getKeyringsByType is deprecated for that same reason.

Additionally, move getMnemonic and getMnemonicSeed to utility functions that can be re-used.

Changelog

CHANGELOG entry: null

Note

Medium Risk
Touches keyring entropy retrieval paths used by Snaps; incorrect assumptions about keyring shape/types could break Snap initialization or restricted methods despite being a scoped refactor.

Overview
Refactors Snap entropy access to use KeyringController:withKeyring instead of the deprecated getKeyringsByType, reducing the chance of races when retrieving the primary HD keyring’s mnemonic/seed.

The mnemonic/seed lookup logic is centralized into new reusable utilities (controllers/permissions/snaps/utils.ts) and wired into both Snap permission specifications and SnapController initialization; legacy metamask-controller helpers/tests for primary keyring mnemonic access are removed. Dependency/policy updates add a direct @metamask/eth-hd-keyring dependency and adjust LavaMoat policies accordingly.

^{Written by Cursor Bugbot for commit b8717b6. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-02-20T15:49:25Z

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (4 files, +130 -117)

📁 app/
- 📁 scripts/
  - 📁 controller-init/
    - 📁 messengers/
      - 📁 snaps/
        
        📄 snap-controller-messenger.ts +3 -3
    - 📁 snaps/
      - 📄 snap-controller-init.ts +3 -20
  - 📁 controllers/
    - 📁 permissions/
      - 📁 snaps/
        
        📄 specifications.ts +3 -94
        
        📄 utils.ts +121 -0

📜 @MetaMask/policy-reviewers (12 files, +208 -176)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +15 -14
  - 📁 experimental/
    - 📄 policy.json +15 -14
  - 📁 flask/
    - 📄 policy.json +15 -14
  - 📁 main/
    - 📄 policy.json +15 -14
- 📁 webpack/
  - 📁 mv2/
    - 📁 beta/
      - 📄 policy.json +16 -15
    - 📁 experimental/
      - 📄 policy.json +16 -15
    - 📁 flask/
      - 📄 policy.json +16 -15
    - 📁 main/
      - 📄 policy.json +16 -15
  - 📁 mv3/
    - 📁 beta/
      - 📄 policy.json +21 -15
    - 📁 experimental/
      - 📄 policy.json +21 -15
    - 📁 flask/
      - 📄 policy.json +21 -15
    - 📁 main/
      - 📄 policy.json +21 -15

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

metamaskbotv2 · 2026-02-20T16:23:51Z

Builds ready [0dba3d3]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1372 ± 100 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 294 28 305 337
total 294 28 305 337
Confirm Tx confirm_tx 6048 8 6054 6055
total 6048 8 6054 6055
Bridge User Actions bridge_load_page 262 8 261 274
bridge_load_asset_picker 189 32 204 229
bridge_search_token 726 23 750 757
total 1145 24 1159 1174

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1372 1169 1617 100 1422 1536
load 1173 974 1391 91 1221 1338
domContentLoaded 1167 969 1387 90 1214 1327
domInteractive 25 15 102 19 22 77
firstPaint 167 67 1247 136 218 367
backgroundConnect 197 182 259 14 198 224
firstReactRender 18 11 44 5 19 23
initialActions 1 0 4 1 1 3
loadScripts 985 792 1212 90 1037 1142
setupStore 13 6 54 7 16 23
numNetworkReqs 31 22 88 20 22 85
Chrome Browserify Startup Power User Home uiStartup 3446 1398 9780 1840 4521 6351
load 1197 1047 1615 114 1230 1456
domContentLoaded 1183 1034 1599 112 1211 1444
domInteractive 32 19 123 18 31 59
firstPaint 167 80 365 75 237 282
backgroundConnect 1175 245 4899 1040 1676 3268
firstReactRender 23 16 65 6 25 30
initialActions 1 0 5 1 1 1
loadScripts 982 839 1403 111 1012 1236
setupStore 14 5 225 22 13 22
numNetworkReqs 81 39 146 24 98 120
Chrome Webpack Startup Standard Home uiStartup 817 652 1216 108 872 1001
load 695 578 968 91 759 855
domContentLoaded 689 572 961 91 754 847
domInteractive 25 15 96 19 21 80
firstPaint 121 57 803 93 146 288
backgroundConnect 26 18 92 10 27 44
firstReactRender 17 10 37 5 19 28
initialActions 1 0 3 1 1 2
loadScripts 687 571 954 90 752 840
setupStore 11 5 34 4 11 19
numNetworkReqs 31 22 102 22 25 92
Chrome Webpack Startup Power User Home uiStartup 1281 882 2966 308 1315 1739
load 757 663 1168 109 778 1005
domContentLoaded 746 652 1163 110 769 999
domInteractive 42 21 199 33 39 126
firstPaint 142 78 358 67 152 296
backgroundConnect 202 131 1584 211 166 337
firstReactRender 22 16 43 4 23 28
initialActions 1 0 2 0 1 1
loadScripts 743 650 1155 108 766 989
setupStore 12 4 28 4 15 20
numNetworkReqs 133 60 261 39 154 211
Firefox Browserify Startup Standard Home uiStartup 1633 1386 2595 264 1628 2213
load 1369 1173 2275 207 1394 1741
domContentLoaded 1367 1172 2275 207 1392 1736
domInteractive 78 31 953 104 83 148
firstPaint - - - - - -
backgroundConnect 61 29 358 42 60 125
firstReactRender 14 11 56 5 14 16
initialActions 1 0 2 0 1 2
loadScripts 1342 1150 2239 200 1371 1704
setupStore 19 7 156 27 15 43
numNetworkReqs 31 19 102 21 25 90
Firefox Browserify Startup Power User Home uiStartup 3026 2106 8493 1009 3085 3915
load 1748 1353 6907 923 1681 2620
domContentLoaded 1747 1353 6907 923 1681 2619
domInteractive 199 63 1756 268 178 451
firstPaint - - - - - -
backgroundConnect 480 123 1732 362 769 1119
firstReactRender 19 14 61 6 19 28
initialActions 1 0 3 1 2 2
loadScripts 1704 1332 6850 919 1626 2597
setupStore 157 15 1211 203 200 572
numNetworkReqs 89 38 228 36 107 166
Firefox Webpack Startup Standard Home uiStartup 1705 1443 3293 261 1713 1950
load 1441 1223 3001 244 1467 1677
domContentLoaded 1441 1222 3001 244 1462 1677
domInteractive 90 28 363 53 129 151
firstPaint - - - - - -
backgroundConnect 56 22 211 32 59 109
firstReactRender 16 12 70 6 16 23
initialActions 1 0 3 1 2 2
loadScripts 1418 1200 2966 241 1439 1625
setupStore 24 7 154 30 20 65
numNetworkReqs 31 20 93 18 27 83
Firefox Webpack Startup Power User Home uiStartup 2988 2263 10397 857 3215 3833
load 1687 1365 8193 691 1674 2199
domContentLoaded 1687 1364 8192 691 1674 2199
domInteractive 183 54 789 168 187 623
firstPaint - - - - - -
backgroundConnect 540 118 1826 378 718 1317
firstReactRender 23 17 91 9 24 33
initialActions 2 1 3 1 2 2
loadScripts 1644 1334 8151 691 1627 2162
setupStore 132 22 776 137 152 439
numNetworkReqs 85 30 231 45 85 214

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 1 219 221
srpButtonToSrpForm 92 2 93 93
confirmSrpToPwForm 21 0 22 22
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 15 0 15 16
doneButtonToHomeScreen 1076 361 1388 1433
openAccountMenuToAccountListLoaded 7125 113 7234 7241
total 8866 104 8887 9027
Onboarding New Wallet createWalletToSocialScreen 218 1 219 219
srpButtonToPwForm 104 1 104 106
createPwToRecoveryScreen 8 0 8 8
skipBackupToMetricsScreen 34 0 34 34
agreeButtonToOnboardingSuccess 15 0 15 15
doneButtonToAssetList 575 90 615 705
total 954 90 992 1087
Asset Details assetClickToPriceChart 46 14 63 64
total 46 14 63 64
Solana Asset Details assetClickToPriceChart 47 0 47 47
total 47 0 47 47
Import Srp Home loginToHomeScreen 1980 85 2058 2071
openAccountMenuAfterLogin 46 8 49 61
homeAfterImportWithNewWallet 2686 180 2837 2937
total 4793 343 4956 5384
Send Transactions openSendPageFromHome 17 1 17 18
selectTokenToSendFormLoaded 20 1 20 21
reviewTransactionToConfirmationPage 856 11 864 874
total 897 11 908 909
Swap openSwapPageFromHome 107 19 122 130
fetchAndDisplaySwapQuotes 4632 73 4669 4758
total 4740 75 4799 4857

🌐 Dapp Page Load Benchmarks

Current Commit: 0dba3d3 | Date: 2/20/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±39ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±36ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	39ms	1.02s	1.36s	1.06s	1.36s
domContentLoaded	733ms	36ms	709ms	1.01s	741ms	1.01s
firstPaint	78ms	12ms	56ms	184ms	88ms	184ms
firstContentfulPaint	78ms	12ms	56ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 6.57 KiB (0.15%)
ui: 23.22 KiB (0.28%)
common: 2.84 KiB (0.03%)

FrederikBolding · 2026-02-20T16:35:34Z

-  /**
-   * Gets the mnemonic of the user's primary keyring.
-   */
-  getPrimaryKeyringMnemonic() {


metamaskbotv2 · 2026-02-20T17:05:01Z

Builds ready [92a9d64]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1368 ± 103 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 279 17 289 305
total 279 17 289 305
Confirm Tx confirm_tx 6035 7 6042 6042
total 6035 7 6042 6042
Bridge User Actions bridge_load_page 222 29 241 267
bridge_load_asset_picker 185 42 203 248
bridge_search_token 703 7 701 714
total 1098 9 1106 1107

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1368 1155 1669 103 1423 1563
load 1155 946 1381 97 1218 1336
domContentLoaded 1147 942 1377 96 1211 1321
domInteractive 27 16 95 20 23 85
firstPaint 214 59 1240 226 210 364
backgroundConnect 208 190 249 13 210 234
firstReactRender 17 10 78 7 18 22
initialActions 1 0 5 1 1 3
loadScripts 958 752 1175 97 1023 1135
setupStore 12 5 37 5 13 20
numNetworkReqs 31 22 94 20 23 88
Chrome Browserify Startup Power User Home uiStartup 1847 1339 10226 956 1779 2094
load 1126 998 1697 144 1130 1510
domContentLoaded 1111 987 1692 139 1117 1425
domInteractive 33 19 175 23 35 70
firstPaint 172 70 1425 146 234 304
backgroundConnect 398 245 7976 820 289 342
firstReactRender 24 15 48 7 26 39
initialActions 1 0 11 1 1 2
loadScripts 912 799 1470 135 923 1218
setupStore 16 8 36 6 18 27
numNetworkReqs 61 37 155 25 64 122
Chrome Webpack Startup Standard Home uiStartup 923 728 1449 118 973 1151
load 782 643 1124 102 849 949
domContentLoaded 776 640 1115 101 843 943
domInteractive 32 17 131 25 25 94
firstPaint 125 65 431 71 144 234
backgroundConnect 28 18 61 8 30 46
firstReactRender 22 13 200 21 22 35
initialActions 1 0 11 1 1 2
loadScripts 773 637 1105 100 840 935
setupStore 13 7 39 6 13 24
numNetworkReqs 31 22 89 19 25 79
Chrome Webpack Startup Power User Home uiStartup 1191 962 1581 139 1287 1465
load 700 621 1050 100 692 974
domContentLoaded 691 614 1040 99 682 940
domInteractive 34 17 135 27 32 113
firstPaint 123 65 308 59 141 244
backgroundConnect 164 61 382 52 162 281
firstReactRender 22 17 29 3 23 27
initialActions 1 0 2 1 1 1
loadScripts 688 612 1028 96 680 930
setupStore 12 5 31 3 13 16
numNetworkReqs 108 38 264 50 137 236
Firefox Browserify Startup Standard Home uiStartup 1621 1367 2684 190 1647 1952
load 1371 1174 2331 159 1400 1596
domContentLoaded 1370 1174 2331 159 1400 1596
domInteractive 78 29 270 44 102 157
firstPaint - - - - - -
backgroundConnect 57 27 180 23 63 102
firstReactRender 13 10 23 2 14 17
initialActions 1 0 2 1 2 2
loadScripts 1344 1156 2302 153 1377 1551
setupStore 19 6 141 26 15 69
numNetworkReqs 31 19 92 19 27 88
Firefox Browserify Startup Power User Home uiStartup 2642 2042 6714 524 2727 3419
load 1564 1224 5068 412 1609 2164
domContentLoaded 1564 1224 5067 412 1609 2163
domInteractive 125 37 538 99 126 355
firstPaint - - - - - -
backgroundConnect 245 100 1028 198 233 806
firstReactRender 18 14 59 6 17 25
initialActions 2 0 7 1 2 2
loadScripts 1525 1207 4956 401 1571 2101
setupStore 127 8 701 173 162 534
numNetworkReqs 64 28 166 33 88 119
Firefox Webpack Startup Standard Home uiStartup 1807 1516 3438 326 1785 2158
load 1518 1285 3068 262 1515 1741
domContentLoaded 1517 1285 3067 262 1515 1741
domInteractive 100 30 211 38 131 144
firstPaint - - - - - -
backgroundConnect 78 28 1417 139 76 111
firstReactRender 16 12 29 3 17 25
initialActions 1 0 3 1 2 2
loadScripts 1492 1261 3026 259 1489 1681
setupStore 25 8 198 34 19 76
numNetworkReqs 31 19 84 16 27 76
Firefox Webpack Startup Power User Home uiStartup 2742 1960 4086 447 2899 3640
load 1602 1294 2590 305 1717 2310
domContentLoaded 1602 1293 2590 305 1716 2310
domInteractive 135 31 768 154 119 611
firstPaint - - - - - -
backgroundConnect 318 107 1359 293 273 961
firstReactRender 21 15 73 10 22 30
initialActions 2 0 6 1 2 2
loadScripts 1556 1273 2570 281 1668 2188
setupStore 208 10 782 228 323 702
numNetworkReqs 64 28 186 35 84 126

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 1 217 219
srpButtonToSrpForm 91 2 92 94
confirmSrpToPwForm 22 0 22 22
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 15 1 16 16
doneButtonToHomeScreen 580 15 581 604
openAccountMenuToAccountListLoaded 7604 394 7834 8074
total 8791 26 8829 8829
Onboarding New Wallet createWalletToSocialScreen 220 2 222 222
srpButtonToPwForm 109 3 109 114
createPwToRecoveryScreen 8 0 8 8
skipBackupToMetricsScreen 36 1 36 36
agreeButtonToOnboardingSuccess 17 0 17 17
doneButtonToAssetList 552 86 567 687
total 940 87 955 1076
Asset Details assetClickToPriceChart 38 1 40 40
total 38 1 40 40
Solana Asset Details assetClickToPriceChart 47 2 49 49
total 47 2 49 49
Import Srp Home loginToHomeScreen 2051 142 2186 2255
openAccountMenuAfterLogin 54 11 65 68
homeAfterImportWithNewWallet 2448 168 2574 2656
total 4552 165 4661 4810
Send Transactions openSendPageFromHome 17 1 18 18
selectTokenToSendFormLoaded 20 1 21 21
reviewTransactionToConfirmationPage 852 5 850 860
total 888 6 889 897
Swap openSwapPageFromHome 134 19 150 158
fetchAndDisplaySwapQuotes 4645 77 4615 4776
total 4780 91 4774 4926

🌐 Dapp Page Load Benchmarks

Current Commit: 92a9d64 | Date: 2/20/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±37ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±34ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	37ms	1.01s	1.31s	1.05s	1.31s
domContentLoaded	720ms	34ms	697ms	976ms	738ms	976ms
firstPaint	77ms	12ms	60ms	184ms	88ms	184ms
firstContentfulPaint	77ms	12ms	60ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 6.68 KiB (0.15%)
ui: 23.56 KiB (0.28%)
common: 3.13 KiB (0.03%)

metamaskbotv2 · 2026-02-23T10:02:37Z

Builds ready [e00dd31]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1374 ± 98 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 271 7 273 281
total 271 7 273 281
Confirm Tx confirm_tx 6037 10 6042 6051
total 6037 10 6042 6051
Bridge User Actions bridge_load_page 258 10 269 269
bridge_load_asset_picker 213 8 219 219
bridge_search_token 719 20 730 749
total 1183 69 1244 1265

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1374 1129 1617 98 1426 1554
load 1164 952 1383 92 1212 1335
domContentLoaded 1157 946 1360 90 1207 1317
domInteractive 28 16 135 21 24 80
firstPaint 158 66 1153 124 206 290
backgroundConnect 204 185 254 14 207 232
firstReactRender 18 12 38 4 19 26
initialActions 1 0 8 1 1 4
loadScripts 971 756 1175 90 1017 1133
setupStore 13 6 40 6 15 23
numNetworkReqs 31 22 88 19 24 83
Chrome Browserify Startup Power User Home uiStartup 1713 1353 2252 169 1761 2093
load 1138 1019 1680 152 1124 1596
domContentLoaded 1125 1011 1672 149 1110 1584
domInteractive 39 20 185 35 36 139
firstPaint 162 75 475 84 223 299
backgroundConnect 284 254 384 20 290 326
firstReactRender 25 16 50 8 28 44
initialActions 1 0 9 1 1 3
loadScripts 921 805 1468 148 902 1369
setupStore 18 7 61 9 21 34
numNetworkReqs 59 37 152 26 57 137
Chrome Webpack Startup Standard Home uiStartup 868 693 1283 109 898 1095
load 741 609 1052 88 795 886
domContentLoaded 735 606 1046 88 788 880
domInteractive 29 16 118 22 24 80
firstPaint 112 60 410 59 126 207
backgroundConnect 26 19 55 8 29 41
firstReactRender 18 12 38 6 20 31
initialActions 1 0 2 1 1 2
loadScripts 732 604 1044 87 786 873
setupStore 12 5 50 6 13 18
numNetworkReqs 31 22 96 20 25 87
Chrome Webpack Startup Power User Home uiStartup 1230 868 2012 159 1322 1471
load 714 635 1366 120 702 998
domContentLoaded 705 628 1351 119 693 992
domInteractive 36 18 153 28 34 111
firstPaint 131 63 475 70 150 274
backgroundConnect 173 130 339 46 169 295
firstReactRender 23 17 43 4 25 29
initialActions 1 0 4 1 1 1
loadScripts 702 625 1333 116 690 982
setupStore 12 5 39 6 14 18
numNetworkReqs 108 42 259 50 138 205
Firefox Browserify Startup Standard Home uiStartup 1584 1369 1981 147 1609 1911
load 1338 1157 1665 118 1380 1565
domContentLoaded 1337 1157 1665 118 1379 1565
domInteractive 74 31 240 41 92 145
firstPaint - - - - - -
backgroundConnect 51 28 124 16 55 78
firstReactRender 13 11 20 2 14 16
initialActions 1 0 2 0 1 2
loadScripts 1314 1135 1648 115 1353 1541
setupStore 19 6 210 33 14 33
numNetworkReqs 31 20 101 21 25 90
Firefox Browserify Startup Power User Home uiStartup 2609 2026 3895 363 2707 3395
load 1533 1228 2316 246 1561 2110
domContentLoaded 1532 1227 2316 246 1561 2109
domInteractive 114 36 514 105 109 348
firstPaint - - - - - -
backgroundConnect 210 96 878 164 200 783
firstReactRender 19 14 99 12 17 26
initialActions 1 0 3 1 2 2
loadScripts 1495 1212 2293 236 1514 2066
setupStore 139 7 727 179 165 541
numNetworkReqs 60 28 143 36 81 140
Firefox Webpack Startup Standard Home uiStartup 1705 1418 3730 357 1706 2006
load 1455 1213 3439 326 1431 1594
domContentLoaded 1454 1213 3438 326 1431 1594
domInteractive 98 31 301 46 131 151
firstPaint - - - - - -
backgroundConnect 84 25 2189 218 62 159
firstReactRender 15 12 27 3 16 23
initialActions 1 0 2 0 2 2
loadScripts 1406 1193 3180 254 1407 1518
setupStore 17 7 140 20 13 43
numNetworkReqs 31 19 90 17 28 81
Firefox Webpack Startup Power User Home uiStartup 2714 1895 3890 436 2831 3683
load 1578 1283 2579 279 1736 2141
domContentLoaded 1577 1283 2579 279 1736 2141
domInteractive 118 31 835 129 103 355
firstPaint - - - - - -
backgroundConnect 272 79 1293 230 245 700
firstReactRender 24 15 174 18 24 30
initialActions 2 0 3 1 2 3
loadScripts 1540 1264 2553 272 1700 2122
setupStore 173 6 1172 239 229 735
numNetworkReqs 58 26 159 36 83 130

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 1 218 218
srpButtonToSrpForm 90 2 91 92
confirmSrpToPwForm 21 0 21 21
pwFormToMetricsScreen 15 1 15 16
metricsToWalletReadyScreen 15 0 15 16
doneButtonToHomeScreen 967 376 1356 1462
openAccountMenuToAccountListLoaded 7280 571 7684 7870
total 8605 240 8807 8906
Onboarding New Wallet createWalletToSocialScreen 220 1 221 222
srpButtonToPwForm 116 10 120 132
createPwToRecoveryScreen 8 0 9 9
skipBackupToMetricsScreen 35 2 37 38
agreeButtonToOnboardingSuccess 16 0 16 17
doneButtonToAssetList 538 53 534 624
total 937 47 946 1011
Asset Details assetClickToPriceChart 41 4 43 45
total 41 4 43 45
Solana Asset Details assetClickToPriceChart 47 1 47 48
total 47 1 47 48
Import Srp Home loginToHomeScreen 1914 44 1931 1993
openAccountMenuAfterLogin 40 1 40 41
homeAfterImportWithNewWallet 2393 29 2389 2442
total 4393 104 4475 4552
Send Transactions openSendPageFromHome 36 15 51 52
selectTokenToSendFormLoaded 30 9 40 41
reviewTransactionToConfirmationPage 867 23 878 907
total 932 7 939 939
Swap openSwapPageFromHome 138 7 141 147
fetchAndDisplaySwapQuotes 5307 828 6253 6381
total 5440 826 6368 6528

🌐 Dapp Page Load Benchmarks

Current Commit: e00dd31 | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 715ms (±36ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	38ms	1.00s	1.31s	1.04s	1.31s
domContentLoaded	715ms	36ms	689ms	988ms	730ms	988ms
firstPaint	74ms	10ms	60ms	156ms	84ms	156ms
firstContentfulPaint	74ms	10ms	60ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: -112 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

Mrtenz · 2026-02-23T10:32:55Z

-      !hasProperty(keyrings[0], 'seed') ||
-      !(keyrings[0].seed instanceof Uint8Array)
-    ) {
+    const { seed } = (await initMessenger.call(


Maybe a good opportunity to move this to a shared function.

Mrtenz · 2026-02-23T10:33:18Z

+        index: 0,
+      },
+      async ({ keyring }) => ({
+        seed: hasProperty(keyring, 'seed') ? keyring.seed : undefined,


Does keyring have a type or something that we could check, instead of hasProperty?

I think we can just cast. I would use the generic parameter for withKeyring but it isn't available via the messenger.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

FrederikBolding · 2026-02-23T11:38:31Z

@metamaskbot update-policies

socket-security · 2026-02-23T11:39:15Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/eth-hd-keyring@13.0.0 ⏵ 13.1.0				⁺⁶

View full report

metamaskbot · 2026-02-23T11:49:28Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/browserify/beta/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/experimental/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/browserify/flask/policy.json changes differ from main/policy.json policy changes
👀 lavamoat/webpack/mv2/beta/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from mv2/main/policy.json policy changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from mv3/main/policy.json policy changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from mv3/main/policy.json policy changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from mv3/main/policy.json policy changes

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

Mrtenz

Policies & code look good to me.

Mrtenz · 2026-02-23T12:11:53Z

      }
    },
-    "@metamask/keyring-controller>@metamask/eth-hd-keyring": {
+    "@metamask/eth-hd-keyring": {


Policy changes are caused by @metamask/eth-hd-keyring now being a direct dependency. No new capabilities introduced.

metamaskbotv2 · 2026-02-23T12:42:25Z

Builds ready [b8717b6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (1353 ± 108 ms)

👆 Interaction Benchmarks
Action Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 266 5 270 271
total 266 5 270 271
Confirm Tx confirm_tx 6024 4 6022 6030
total 6024 4 6022 6030
Bridge User Actions bridge_load_page 239 11 244 255
bridge_load_asset_picker 157 27 160 193
bridge_search_token 698 5 699 705
total 1087 15 1090 1106

🔌 Startup Benchmarks
Build Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P 75 (ms) P 95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1353 1120 1652 108 1388 1566
load 1141 949 1364 95 1183 1322
domContentLoaded 1134 946 1359 94 1179 1316
domInteractive 26 14 93 19 21 78
firstPaint 222 61 1258 231 216 967
backgroundConnect 201 182 249 13 207 224
firstReactRender 17 12 33 4 19 24
initialActions 1 0 4 1 1 3
loadScripts 949 756 1174 93 991 1126
setupStore 12 6 42 5 13 19
numNetworkReqs 31 22 98 21 22 93
Chrome Browserify Startup Power User Home uiStartup 1713 1409 2296 155 1777 2001
load 1146 1008 1696 151 1129 1588
domContentLoaded 1128 1000 1637 137 1115 1511
domInteractive 33 19 117 18 34 83
firstPaint 205 72 1519 160 259 367
backgroundConnect 285 253 370 22 293 330
firstReactRender 23 15 48 6 24 36
initialActions 1 0 3 1 1 1
loadScripts 922 814 1395 135 905 1304
setupStore 17 7 72 11 18 37
numNetworkReqs 58 37 151 25 56 124
Chrome Webpack Startup Standard Home uiStartup 878 693 1190 104 934 1099
load 741 617 1007 97 801 929
domContentLoaded 735 612 1001 96 796 922
domInteractive 28 16 117 19 25 73
firstPaint 119 62 405 61 160 227
backgroundConnect 29 19 70 9 33 46
firstReactRender 19 12 41 6 21 30
initialActions 1 0 4 1 1 2
loadScripts 733 610 999 95 794 914
setupStore 12 6 37 5 12 23
numNetworkReqs 31 22 97 20 25 87
Chrome Webpack Startup Power User Home uiStartup 1229 894 1680 158 1323 1517
load 700 624 1051 100 694 975
domContentLoaded 691 618 1041 99 683 967
domInteractive 34 18 148 25 31 101
firstPaint 127 64 423 69 149 264
backgroundConnect 170 128 382 47 163 283
firstReactRender 22 16 38 4 24 28
initialActions 1 0 2 0 1 1
loadScripts 688 616 1029 97 681 958
setupStore 13 5 49 7 13 33
numNetworkReqs 107 37 262 51 137 222
Firefox Browserify Startup Standard Home uiStartup 1686 1411 2518 215 1733 2055
load 1420 1187 2235 182 1469 1774
domContentLoaded 1419 1187 2234 182 1468 1774
domInteractive 92 32 269 47 135 178
firstPaint - - - - - -
backgroundConnect 63 31 216 28 66 127
firstReactRender 14 12 17 1 14 16
initialActions 1 0 2 1 1 2
loadScripts 1391 1163 2200 177 1433 1737
setupStore 21 8 158 27 16 54
numNetworkReqs 32 19 96 20 26 93
Firefox Browserify Startup Power User Home uiStartup 2770 2154 3980 385 2900 3538
load 1593 1280 2764 275 1649 2228
domContentLoaded 1593 1280 2763 275 1649 2227
domInteractive 138 36 1036 151 123 437
firstPaint - - - - - -
backgroundConnect 331 118 1221 268 381 903
firstReactRender 19 15 70 9 19 23
initialActions 1 0 3 1 2 2
loadScripts 1551 1257 2724 264 1605 2186
setupStore 139 8 787 204 138 640
numNetworkReqs 64 29 188 31 85 113
Firefox Webpack Startup Standard Home uiStartup 1643 1381 3261 247 1663 1945
load 1375 1146 2863 172 1410 1510
domContentLoaded 1374 1141 2863 172 1410 1510
domInteractive 78 26 179 42 105 148
firstPaint - - - - - -
backgroundConnect 72 24 1418 140 61 168
firstReactRender 15 12 32 4 15 24
initialActions 1 0 3 1 2 2
loadScripts 1353 1130 2841 171 1392 1473
setupStore 19 7 182 29 13 60
numNetworkReqs 31 19 98 19 27 83
Firefox Webpack Startup Power User Home uiStartup 2687 1907 7052 563 2790 3377
load 1583 1238 5740 477 1613 1999
domContentLoaded 1583 1238 5740 477 1613 1999
domInteractive 119 30 691 111 120 332
firstPaint - - - - - -
backgroundConnect 267 72 900 205 281 829
firstReactRender 20 16 35 4 22 28
initialActions 2 0 3 1 2 2
loadScripts 1554 1217 5705 475 1587 1982
setupStore 159 9 816 198 232 701
numNetworkReqs 63 28 215 38 81 128

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 1 217 218
srpButtonToSrpForm 90 1 91 92
confirmSrpToPwForm 21 0 21 21
pwFormToMetricsScreen 15 0 15 15
metricsToWalletReadyScreen 15 0 16 16
doneButtonToHomeScreen 998 343 1247 1368
openAccountMenuToAccountListLoaded 7142 97 7224 7224
total 8408 403 8766 8832
Onboarding New Wallet createWalletToSocialScreen 219 1 219 221
srpButtonToPwForm 105 3 106 109
createPwToRecoveryScreen 8 0 8 8
skipBackupToMetricsScreen 37 3 40 41
agreeButtonToOnboardingSuccess 16 1 16 16
doneButtonToAssetList 752 210 835 1130
total 1138 212 1233 1514
Asset Details assetClickToPriceChart 36 2 36 39
total 36 2 36 39
Solana Asset Details assetClickToPriceChart 58 2 60 60
total 58 2 60 60
Import Srp Home loginToHomeScreen 2217 230 2455 2534
openAccountMenuAfterLogin 41 4 43 48
homeAfterImportWithNewWallet 2279 37 2321 2321
total 4421 329 4714 4824
Send Transactions openSendPageFromHome 18 1 18 19
selectTokenToSendFormLoaded 21 2 23 23
reviewTransactionToConfirmationPage 869 12 874 891
total 903 5 902 910
Swap openSwapPageFromHome 111 8 115 123
fetchAndDisplaySwapQuotes 4638 9 4645 4645
total 4734 23 4749 4759

🌐 Dapp Page Load Benchmarks

Current Commit: b8717b6 | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±53ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 726ms (±50ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	53ms	1.01s	1.32s	1.08s	1.32s
domContentLoaded	726ms	50ms	699ms	1.01s	759ms	1.01s
firstPaint	77ms	13ms	60ms	192ms	84ms	192ms
firstContentfulPaint	77ms	13ms	60ms	192ms	84ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -204 Bytes (0%)
ui: 11 Bytes (0%)
common: 3.06 KiB (0.03%)

FrederikBolding temporarily deployed to pr-comment February 20, 2026 15:48 — with GitHub Actions Inactive

metamaskbot added the team-core-platform Core Platform team label Feb 20, 2026

github-actions Bot added the size-M label Feb 20, 2026

FrederikBolding temporarily deployed to pr-comment February 20, 2026 16:19 — with GitHub Actions Inactive

FrederikBolding commented Feb 20, 2026

View reviewed changes

FrederikBolding temporarily deployed to pr-comment February 20, 2026 16:36 — with GitHub Actions Inactive

FrederikBolding temporarily deployed to pr-comment February 20, 2026 17:00 — with GitHub Actions Inactive

FrederikBolding temporarily deployed to pr-comment February 23, 2026 09:17 — with GitHub Actions Inactive

FrederikBolding force-pushed the fb/snaps-with-keyring branch from f712bf5 to e00dd31 Compare February 23, 2026 09:26

FrederikBolding temporarily deployed to pr-comment February 23, 2026 09:26 — with GitHub Actions Inactive

FrederikBolding temporarily deployed to pr-comment February 23, 2026 09:57 — with GitHub Actions Inactive

Mrtenz requested changes Feb 23, 2026

View reviewed changes

FrederikBolding temporarily deployed to pr-comment February 23, 2026 11:21 — with GitHub Actions Inactive

FrederikBolding added 4 commits February 23, 2026 12:22

fix: Use withKeyring for accessing keyring entropy for Snaps

f921836

Remove unused unit test

d5677a2

Remove unused import

c14c631

Refactor

4ba2c74

FrederikBolding force-pushed the fb/snaps-with-keyring branch from f131d06 to 4ba2c74 Compare February 23, 2026 11:22

FrederikBolding marked this pull request as ready for review February 23, 2026 11:22

FrederikBolding had a problem deploying to pr-comment February 23, 2026 11:22 — with GitHub Actions Error

FrederikBolding requested a review from a team as a code owner February 23, 2026 11:22

FrederikBolding temporarily deployed to pr-comment February 23, 2026 11:22 — with GitHub Actions Inactive

FrederikBolding requested a review from Mrtenz February 23, 2026 11:23

cursor Bot reviewed Feb 23, 2026

View reviewed changes

Comment thread app/scripts/controllers/permissions/snaps/utils.ts

Comment thread app/scripts/controller-init/snaps/snap-controller-init.ts

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 23, 2026

Add eth-hd-keyring as direct dependency

8baea33

FrederikBolding temporarily deployed to pr-comment February 23, 2026 11:38 — with GitHub Actions Inactive

Update LavaMoat policies

5a1c309

metamaskbot requested a review from a team as a code owner February 23, 2026 11:49

metamaskbot temporarily deployed to pr-comment February 23, 2026 11:49 — with GitHub Actions Inactive

Mrtenz reviewed Feb 23, 2026

View reviewed changes

Comment thread app/scripts/controllers/permissions/snaps/utils.ts Outdated

Update app/scripts/controllers/permissions/snaps/utils.ts

b8717b6

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

FrederikBolding temporarily deployed to pr-comment February 23, 2026 12:10 — with GitHub Actions Inactive

Mrtenz approved these changes Feb 23, 2026

View reviewed changes

FrederikBolding temporarily deployed to pr-comment February 23, 2026 12:38 — with GitHub Actions Inactive

GuillaumeRx approved these changes Feb 23, 2026

View reviewed changes

FrederikBolding added this pull request to the merge queue Feb 23, 2026

Merged via the queue into main with commit 324fd45 Feb 23, 2026
177 checks passed

FrederikBolding deleted the fb/snaps-with-keyring branch February 23, 2026 15:01

github-actions Bot locked and limited conversation to collaborators Feb 23, 2026

metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 23, 2026

Uh oh!

Conversation

FrederikBolding commented Feb 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Uh oh!

metamaskbotv2 Bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 Bot commented Feb 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

FrederikBolding Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

metamaskbotv2 Bot commented Feb 20, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 Bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Mrtenz Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

FrederikBolding Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Mrtenz Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

FrederikBolding Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FrederikBolding commented Feb 23, 2026

Uh oh!

socket-security Bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Feb 23, 2026

Uh oh!

Uh oh!

Mrtenz left a comment

Choose a reason for hiding this comment

Uh oh!

Mrtenz Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

metamaskbotv2 Bot commented Feb 23, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FrederikBolding commented Feb 20, 2026 •

edited by cursor Bot

Loading

metamaskbotv2 Bot commented Feb 20, 2026 •

edited

Loading

FrederikBolding Feb 23, 2026 •

edited

Loading

socket-security Bot commented Feb 23, 2026 •

edited

Loading