chore: remove account identities petnames bridge - #40312
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [12c3638]
⚡ Performance Benchmarks (1421 ± 112 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
…ntities-petnames-bridge
Contributor
Builds ready [d637b91]
⚡ Performance Benchmarks (1464 ± 149 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
mathieuartu
reviewed
Feb 23, 2026
mathieuartu
left a comment
mathieuartu
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM, let me know when E2E is passing (I think you might need to update some files) and I'll approve 😄
Contributor
Author
Yup, it's the fixture stuff. Going to let my other extension PR (#39792) go in first. |
…ntities-petnames-bridge
|
Contributor
Builds ready [991de91]
⚡ Performance Benchmarks (1356 ± 109 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
gantunesr
approved these changes
Feb 25, 2026
owencraston
approved these changes
Feb 25, 2026
metamaskbot
added
the
release-13.21.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
AccountIdentitiesPetnamesBridgehas no functional purpose at the moment and is doing unnecessary computation every time an account is added. We no longer rely on the the internal account's name property and instead use the account group name in the account tree controller through out the extension. The name controller's state was used in the<Name>component to provide a name, but that component already primarily uses the account tree's state to get account names.Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Primarily deletes unused synchronization code and related wiring; risk is limited to any hidden dependency on account-identity-derived petnames updates.
Overview
Removes the
AccountIdentitiesPetnamesBridgeand its unit test, eliminating the one-way sync that copied internal accountmetadata.nameintoNameControllerpetnames.Updates
metamask-controller.jsto stop delegatingAccountsControllerevents/actions to the petnames bridge messenger and to stop initializing the removed bridge, leaving only the address-book-based petnames bridge wired up.Written by Cursor Bugbot for commit 991de91. This will update automatically on new commits. Configure here.