Skip to content

fix: scrolling in asset page#40313

Closed
n3ps wants to merge 1 commit intomainfrom
n3ps/fix-asset-activity
Closed

fix: scrolling in asset page#40313
n3ps wants to merge 1 commit intomainfrom
n3ps/fix-asset-activity

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Feb 21, 2026

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Feb 21, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 21, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +10 -3)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 transaction-list/
          • 📄 unified-transaction-list.component.js +10 -3

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 21, 2026

Builds ready [d8357a4]
⚡ Performance Benchmarks (1383 ± 115 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29220297317
total29220297317
Confirm Txconfirm_tx6059560656065
total6059560656065
Bridge User Actionsbridge_load_page26037270320
bridge_load_asset_picker18449220254
bridge_search_token73125744764
total11756312231251
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup13831164191211514221583
load116797916219912041335
domContentLoaded116197116169811981321
domInteractive2916165242479
firstPaint166661203165206326
backgroundConnect20318334618207228
firstReactRender20125272130
initialActions104114
loadScripts97378814199610091135
setupStore1373951524
numNetworkReqs312287192283
Chrome Browserify Startup Power User HomeuiStartup17061370212714817651963
load11311006160912011171423
domContentLoaded1116990159111511091411
domInteractive3319154223382
firstPaint181741523152232275
backgroundConnect28224835919289318
firstReactRender22154662338
initialActions105112
loadScripts91179214011139061206
setupStore1675071829
numNetworkReqs57361522157104
Chrome Webpack Startup Standard HomeuiStartup88371912231099321120
load744629108695782899
domContentLoaded738626107994777893
domInteractive2916114222483
firstPaint1186292595125227
backgroundConnect28195993247
firstReactRender19124572237
initialActions1010112
loadScripts736624107793775888
setupStore1254361222
numNetworkReqs322295202585
Chrome Webpack Startup Power User HomeuiStartup1179821173615512771482
load690611104994685933
domContentLoaded681605103992676926
domInteractive35171382636112
firstPaint1296641767160251
backgroundConnect16512837849164272
firstReactRender22163132427
initialActions102111
loadScripts678604102990674917
setupStore1355171431
numNetworkReqs1083725950138232
Firefox Browserify Startup Standard HomeuiStartup16621387264024816722135
load14071183239222214271735
domContentLoaded14061183238722214271735
domInteractive76303825888152
firstPaint------
backgroundConnect5927212286094
firstReactRender14113631416
initialActions102012
loadScripts13801159236921514081697
setupStore207190291551
numNetworkReqs312098202586
Firefox Browserify Startup Power User HomeuiStartup27932104458942329333599
load15991281250528216452233
domContentLoaded15991281250428216452233
domInteractive13136753149115558
firstPaint------
backgroundConnect2811181317245248887
firstReactRender201474101926
initialActions203122
loadScripts15551255244826115942162
setupStore1348749195127644
numNetworkReqs57281623373125
Firefox Webpack Startup Standard HomeuiStartup16741309320124916971964
load14161175289521414481568
domContentLoaded14151175289521414481567
domInteractive962925853131192
firstPaint------
backgroundConnect59243774261104
firstReactRender15122931522
initialActions102112
loadScripts13911158287421214221523
setupStore246176321777
numNetworkReqs311998182775
Firefox Webpack Startup Power User HomeuiStartup27592014719259829263572
load16351295584151217402302
domContentLoaded16341294584151217402301
domInteractive12130742141102443
firstPaint------
backgroundConnect264108984209251869
firstReactRender22157592329
initialActions203122
loadScripts15941265581150416982195
setupStore17071180236220680
numNetworkReqs56271313276123
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2201220221
srpButtonToSrpForm9119292
confirmSrpToPwForm2102121
pwFormToMetricsScreen1401515
metricsToWalletReadyScreen1501515
doneButtonToHomeScreen90828411551326
openAccountMenuToAccountListLoaded697365776337825
total824343087628777
Onboarding New WalletcreateWalletToSocialScreen2200220220
srpButtonToPwForm1091110110
createPwToRecoveryScreen8099
skipBackupToMetricsScreen3603636
agreeButtonToOnboardingSuccess1611717
doneButtonToAssetList58373601687
total978679881079
Asset DetailsassetClickToPriceChart3603737
total3603737
Solana Asset DetailsassetClickToPriceChart2302323
total2302323
Import Srp HomeloginToHomeScreen206614621712275
openAccountMenuAfterLogin3743842
homeAfterImportWithNewWallet255115726082769
total466827446995098
Send TransactionsopenSendPageFromHome30114040
selectTokenToSendFormLoaded1912021
reviewTransactionToConfirmationPage8493850852
total90013908917
SwapopenSwapPageFromHome10314111126
fetchAndDisplaySwapQuotes46698446844797
total47768247954895
🌐 Dapp Page Load Benchmarks

Current Commit: d8357a4 | Date: 2/21/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±35ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 37ms 1.01s 1.31s 1.05s 1.31s
domContentLoaded 719ms 35ms 699ms 983ms 731ms 983ms
firstPaint 76ms 13ms 60ms 188ms 84ms 188ms
firstContentfulPaint 76ms 13ms 60ms 188ms 84ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 7.05 KiB (0.16%)
  • ui: 36.54 KiB (0.44%)
  • common: 3.72 KiB (0.03%)

@n3ps n3ps closed this Feb 23, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant