Skip to content

fix: if should not be always true - #40314

Open
cuiweixie wants to merge 2 commits into
MetaMask:mainfrom
cuiweixie:bugfix
Open

fix: if should not be always true#40314
cuiweixie wants to merge 2 commits into
MetaMask:mainfrom
cuiweixie:bugfix

Conversation

@cuiweixie

@cuiweixie cuiweixie commented Feb 21, 2026

Copy link
Copy Markdown

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk UI-only change that fixes an always-truthy conditional affecting avatar overlap spacing; may slightly change layout for some avatar sizes.

Overview
Fixes AvatarGroup’s overlap spacing logic by comparing size against AvatarTokenSize enums (instead of using always-truthy constants), so marginLeftValue is computed correctly for Xs/Sm/default sizes.

Written by Cursor Bugbot for commit 96371b9. This will update automatically on new commits. Configure here.

@cuiweixie
cuiweixie requested a review from a team as a code owner February 21, 2026 13:02
@github-actions

github-actions Bot commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cuiweixie

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@HowardBraham

Copy link
Copy Markdown
Contributor

@cuiweixie I think this is correct, but can you find an actual bug in the client that this fixes?

@cuiweixie

Copy link
Copy Markdown
Author

I have try.But it's hard to find px diff by eye without some tool.

@cuiweixie

Copy link
Copy Markdown
Author

It seems the ci failed is unrelated to the pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants