test: remove withSolanaAccountSnap as we have default Multichain support in all our e2e#40327
Merged
test: remove withSolanaAccountSnap as we have default Multichain support in all our e2e#40327
withSolanaAccountSnap as we have default Multichain support in all our e2e#40327Conversation
seaona
added
skip-e2e-quality-gate
no-changelog
Contributor
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/core-platform (1 files, +11 -4)
🧪 @MetaMask/qa (2 files, +40 -1)
👨🔧 @MetaMask/wallet-integrations (2 files, +38 -23)
|
Contributor
Builds ready [c4700df]
⚡ Performance Benchmarks (1353 ± 98 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [f67bab3]
⚡ Performance Benchmarks (1394 ± 109 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
changed the title
withSolanaAccountSnap as we have default Multichain support in all our e2e
Contributor
Builds ready [c7d5849]
⚡ Performance Benchmarks (1390 ± 92 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
commented
Feb 24, 2026
| }: { | ||
| mockServer: Mockttp; | ||
| balance?: number; | ||
| }) { |
Member
Author
There was a problem hiding this comment.
ℹ️ instead of having mockZeroBalance as bool, we now accept a balance param, which allows us to customize the balance to any value we want
seaona
commented
Feb 24, 2026
|
|
||
| export const SHOW_SWAP_SNAP_CONFIRMATION = false; | ||
|
|
||
| const featureFlags = { |
Member
Author
There was a problem hiding this comment.
this can be removed as not used anywhere
seaona
commented
Feb 24, 2026
| | MockedEndpoint; | ||
| }; | ||
|
|
||
| export async function withSolanaAccountSnap( |
Member
Author
There was a problem hiding this comment.
this was a giant abstraction of test setup+test actions.
This complexity is very much simplified now, by removing duplicated things (as we already have solana/multichain accounts by default), focusing now solely on mocks setup
seaona
commented
Feb 24, 2026
| */ | ||
| export const DEFAULT_SOLANA_TEST_DAPP_FIXTURE_OPTIONS = { | ||
| dappOptions: { | ||
| customDappPaths: [DAPP_PATH.TEST_DAPP_SOLANA], |
Member
Author
There was a problem hiding this comment.
abstraction not needed, we can use the dappOptions like in any other spec
Contributor
Builds ready [795209e]
⚡ Performance Benchmarks (1362 ± 84 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
commented
Feb 25, 2026
| async checkPageIsLoaded(): Promise<void> { | ||
| try { | ||
| await this.driver.waitForMultipleSelectors([ | ||
| this.sendButton, |
Member
Author
There was a problem hiding this comment.
I changed this selector because this checkPageIsLoaded (super) is also used in the non-evm-hompage, but in that page, the send button has a different id. So this could cause confusion -> now using a selector that is common in both
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [603053e]
⚡ Performance Benchmarks (1405 ± 99 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
|
Contributor
Builds ready [891c68a]
⚡ Performance Benchmarks (1364 ± 115 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
javiergarciavera
approved these changes
Feb 26, 2026
Mrtenz
approved these changes
Feb 26, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.21.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
withSolanaAccountSnapmethod, as we have default Multichain support in all our e2e, so we don't need the duplicated setup of feature flags etc (which is already set by default).All specs start the wallet with multichain accounts, meaning this method is now obsolete/missleading/duplicated.
Instead of
withSolanaAccountSnapwe can usewithFixturesout of the box.This simplifies test setup and makes the tests also easier to debug and maintain.
Additional changes:
Note: e2e quality gate is disabled due to the number of specs changed, causing the ci to timeout due to extra test runs.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
This data is for the migration of V2 fixtures (before and after):
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Broad test-harness refactor touching many E2E specs and mocks; risk is primarily increased CI flakiness or missing setup (login/network/account) causing false failures rather than production impact.
Overview
Removes the bespoke Solana E2E harness
withSolanaAccountSnapin favor of usingwithFixturesdirectly across Solana/multichain specs, updating tests to explicitly log in, switch to Solana where needed, and passfixtures/dappOptions/testSpecificMockper scenario.Refactors Solana test mocking by introducing
buildSolanaTestSpecificMock(andSolanaMockOptions) plus a more flexiblemockSolanaBalanceQuotesignature, and updates affected swap/SPL/tx tests accordingly. Adds a reusableaddAccountflow for creating/switching multichain accounts, extendsFixtureBuilderV2withwithShowNativeTokenAsMainBalanceDisabled, and tweaksHomePage.checkPageIsLoadedto wait on the balance section rather than the send button.Written by Cursor Bugbot for commit 891c68a. This will update automatically on new commits. Configure here.